Control: retitle 890468 lintian: source-is-missing false positive when d/missing-sources/foo has no known suffix On Fri 2018-10-26 14:52:38 -0400, Chris Lamb wrote: > Chris Lamb wrote: > >> Thanks for the bug report but unfortunately I think I'm either >> parsing the problem incorrectly or think we are handling this >> correctly already. I've added a testcase here: >> >> https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=2c09091df0c8425e96ac2104b6f49fab8f1f7b10 > > Gentle ping on this? hm, thanks for the ping! I've just tried to replicate it and the problem is subtly different than i thought it was beforehand. I'm attaching an example_1.0.orig.tar.gz and a example_1.0-1.debian.tar.xz The relevant lintian tags printed are: P: example source: source-contains-prebuilt-binary bar E: example source: source-is-missing bar P: example source: source-contains-prebuilt-binary foo E: example source: source-is-missing foo and here's the missing-sources: 0 dkg@alice:~/src/bugs/890468/example$ find debian/missing-sources/ -ls 4973159 4 drwxr-xr-x 3 dkg dkg 4096 Oct 26 15:53 debian/missing-sources/ 4973200 0 lrwxrwxrwx 1 dkg dkg 3 Oct 26 15:53 debian/missing-sources/foo -> bar 4973197 4 drwxr-xr-x 2 dkg dkg 4096 Oct 26 15:48 debian/missing-sources/bar 4973198 4 -rw-r--r-- 1 dkg dkg 27 Oct 26 15:37 debian/missing-sources/bar/main.c 4973199 4 -rw-r--r-- 1 dkg dkg 63 Oct 26 15:37 debian/missing-sources/bar/Makefile 0 dkg@alice:~/src/bugs/890468/example$ so from debian/missing-sources, you can "make foo" and "make bar" with no problem, but lintian doesn't notice that, because it's looking for debian/missing-sources/bar.c or debian/missing-sources/bar.cpp or whatever, but it does not accept not debian/missing-sources/bar/ (a directory) or debian/missing-sources/foo (a symlink) as the source. if i "mv debian/missing-sources/foo{,.c}" then lintian doesn't report "source-is-missing foo" any longer, even though it remains a symlink! Anyway, i think if lintian is looking for source for file FFF and it finds debian/missing-sources/FFF , it should treat that as a match. Does that sound reasonable? --dkg
Attachment:
example_1.0.orig.tar.gz
Description: application/gzip
Attachment:
example_1.0-1.debian.tar.xz
Description: application/xz