[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#906284: marked as done (lintian: check for incomplete-creative-commons-license gives false positives: the "not a law firm" is a preamble, not a license)



Your message dated Fri, 21 Sep 2018 09:19:15 +0000
with message-id <E1g3Hal-0000XO-1K@fasolo.debian.org>
and subject line Bug#906284: fixed in lintian 2.5.104
has caused the Debian Bug report #906284,
regarding lintian: check for incomplete-creative-commons-license gives false positives: the "not a law firm" is a preamble, not a license
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
906284: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=906284
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.5.96
Severity: normal

The test for the human-readable rather than legal text of the Creative
Commons licenses seems to fail, because the preamble about Creative
Commons not being a law firm is not part of the license text, and
neither is the postamble about Creative Commons not being a party to
the license agreement; they are instead form the terms and conditions
between Creative Commons and the person using a CC license.  So I
cannot see why these parts should necessarily be included in the
Debian copyright file.  Has there been a policy decision to require
this, perhaps?

Also, it seems that this check would be better in the parse_license
function when checking each license block rather than the run
function, as there might be more than one CC license in a copyright
file, and it is feasible that one is correct and one not.

Best wishes,

   Julian

-- System Information:
Debian Release: buster/sid
  APT prefers stretch
  APT policy: (500, 'stretch'), (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.14.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8), LANGUAGE=en_GB.utf8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils                       2.31.1-2
ii  bzip2                          1.0.6-8.1
ii  diffstat                       1.61-1+b1
ii  dpkg                           1.19.0.5+b1
ii  file                           1:5.34-2
ii  gettext                        0.19.8.1-6+b1
ii  intltool-debian                0.35.0+20060710.4
ii  libapt-pkg-perl                0.1.34
ii  libarchive-zip-perl            1.60-1
ii  libclass-accessor-perl         0.51-1
ii  libclone-perl                  0.39-1
ii  libdpkg-perl                   1.19.0.5
ii  libemail-valid-perl            1.202-1
ii  libfile-basedir-perl           0.08-1
ii  libipc-run-perl                20180523.0-1
ii  liblist-moreutils-perl         0.416-1+b3
ii  libparse-debianchangelog-perl  1.2.0-12
ii  libtext-levenshtein-perl       0.13-1
ii  libtimedate-perl               2.3000-2
ii  liburi-perl                    1.74-1
ii  libxml-simple-perl             2.25-1
ii  libyaml-libyaml-perl           0.72+repack-1
ii  man-db                         2.8.4-2
ii  patchutils                     0.3.4-2
ii  perl [libdigest-sha-perl]      5.26.2-7
ii  t1utils                        1.41-2
ii  xz-utils                       5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b4

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  dpkg-dev               1.19.0.5
ii  libhtml-parser-perl    3.72-3+b2
ii  libtext-template-perl  1.53-1

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.5.104

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 906284@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 21 Sep 2018 08:13:34 +0000
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.104
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 lintian    - Debian package checker
Closes: 906284 908911 909270 909272
Changes:
 lintian (2.5.104) unstable; urgency=medium
 .
   * checks/description.pm:
     + [CL] Check for overly-indented paragraph separators in package long
       descriptions.  (Closes: #909272)
   * checks/fields.pm:
     + [CL] Apply patches from Josh Triplett to re-use the metapackage
       detection logic from Lintian::Collect::Binary and to allow
       metapackages to depend on toolchain packages.
   * checks/source-copyright.pm:
     + [CL] Fix a number of false-positives when checking for incomplete
       Creative Commons licenses.  Thanks to Jonathan Dowland (jmtd) for
       collecting a corpus of test data.  (Closes: #906284)
     + [CL] Also check the "Source" field when looking for repack
       explanations as per section 6.4 of the machine-readable
       debian/copyright file specification.  (Closes: #909270)
     + [CL] Include the line number in the output of the
       incomplete-creative-commons-license tag.
 .
   * private/refresh-ftp-master-tags:
     + [CL] Remove any duplicates from FTPmaster's list of supplied tags
       when automatically generating the ftp-master-{fatal,nonfatal} data
       files.  This should be fixed upstream via
       <https://salsa.debian.org/ftp-team/dak/merge_requests/101>.
 .
   * profiles/debian/ftp-master-auto-reject.profile:
     + [CL] Refresh tags via private/refresh-ftp-master-tags, specifically
       allowing dir-or-file-in-etc-opt to be overridable.  (Closes: #908911)
Checksums-Sha1:
 4caf0babf22ed335cfaa84c6a4e593d1c0c6cabc 3542 lintian_2.5.104.dsc
 db7a4f79d4c46fcf3de1eadae99d5c4d0156646f 1585892 lintian_2.5.104.tar.xz
 5acf680514ed1034085ec79af1e165d9d7aa0e6f 1135024 lintian_2.5.104_all.deb
 909865814b10a5012606bed22195427112867109 16240 lintian_2.5.104_amd64.buildinfo
Checksums-Sha256:
 f1ffabd8f6c9dd6a507e284701ef4e2ed6702a1c1cc5040ea69916b5eb561fe2 3542 lintian_2.5.104.dsc
 4cc93bf8d358639aff49f99dc8b339b2ebb828e2999f96f210fe4d2e93462aaa 1585892 lintian_2.5.104.tar.xz
 58aa740f4ed3a0833f9b6edf16b3e92f0ae69c94fc56b07634986f5c0c5aa1a4 1135024 lintian_2.5.104_all.deb
 83fe6e31c9c2e5956044e6a8c4b721ba6fbc9a4be836d2c035b34c1d10ec9a65 16240 lintian_2.5.104_amd64.buildinfo
Files:
 2c94aedba8f91736b29d1d237e69dad2 3542 devel optional lintian_2.5.104.dsc
 ed92ba7680a15bdd9392bdf0d10ae488 1585892 devel optional lintian_2.5.104.tar.xz
 8079f054ffb8021a4c6d548a97b7d11d 1135024 devel optional lintian_2.5.104_all.deb
 a7472aa948d31c3f78cb8fe1e05ffbb2 16240 devel optional lintian_2.5.104_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAluktYUACgkQHpU+J9Qx
HlhmGBAAs+S/zZad+OnaQ2DVns4Cn+Y4l9zgU4uwopjvUEobQJYIRCHIrxWofQNE
BslLAglhcV/vTvzJ8NETL1evE+JJkgvjGAhc/FSrCatRm/7HO2SVosbJeyOvkt6R
0OCfiSNQRZGnXSy92vqrAPmT6tMpCY/w252Yjg3RMXi4kqDcrkMtXtdIwg+3Ow6v
Ddd8XYS5PK4I/CP+YTjjLG7BWYI33jm0d6nMgTuDYIBMykYwO6n8jpDyDHZkQOjZ
CbhLQxLIKVne8cU2ZiOOzMMPcNmQezot7N9FopNB56uqim11CJaAMP11iPFQ8DJ/
92XOaR5QPU0+J3KkVp1InA7juKmE/YusCT826nBA+3XOKUavHY5rQQht3Sxa9ieT
+jPA2AtHkCdPchuWs30icyhTVpL512f6IFUhtbI8K7e4RWlvjnsP8huwvFNV9duD
jhSQCDLUMTvYjHyGgnf8jsMgvn1LvP4PDTC3p9mfRI+kLmF6a063JiUOnkFaUFfe
prc2nFNPB3NF1ymZY7AD+cunlwUjCXKxQ0RAiS5hnNw3xepbhtwixPfFTn+mNAKD
A1ZZBC/6pnWX+TwYGnNFAjVmXqT4z7Vvp2q8c3WlVn/Vqn+6fRb0S1Fqlhdh8x9D
+DyVJtq0pKVPKyHCt1Q/ZhlcbvoUXO1lLC2wzC4PhsV+FCay9PU=
=Bmlc
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: