[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#907667: lintian: should html escape output if --color=html is used



Chris Lamb:
> tags 907667 + pending
> thanks
> 
> Fixed in Git, pending upload:
> 
>   https://salsa.debian.org/lintian/lintian/commit/897c485d61387adc5689f287c7e0404e604136e7
> 
>   debian/changelog                              | 5 +++++
>   debian/control                                | 2 ++
>   lib/Lintian/Output.pm                         | 7 +++----
>   t/tests/lintian-color-html/debian/debian/docs | 1 +
>   t/tests/lintian-color-html/debian/foo.xml     | 1 +
>   t/tests/lintian-color-html/desc               | 8 ++++++++
>   t/tests/lintian-color-html/tags               | 1 +
>   7 files changed, 21 insertions(+), 4 deletions(-)
> 
> 
> Regards,
> 


Any reason for introducing the CGI dependency over simply applying the
same escape rules for the $information variable?  Possibly we could
extract the html_quote from commands/reporting-html-reports.pm and put
it in L::Util (or similar) and share the code from there.

Alternatively, if we are moving to a dependency to solve this issue,
then we should use it consistently (i.e. remove html_quote from
commands/reporting-html-reports.pm).

Thanks,
~Niels


Reply to: