Bug#906284: Too many false positives?
Hi folks, sorry for the delay in getting involved.
On Tue, Aug 28, 2018 at 07:43:46AM +0100, Chris Lamb wrote:
Perhaps just looking at the size of the license text (say < 20 lines)
would work better? I don't know perl at all, so I can't help write it,
but I would be quite surprised if that wasn't easy to do for someone
with a minimal knowledge of the language and the codebase.
Let's await Jonathan's input; it's obviously not ideal to have such a
false-positive prone tag.
It certainly looks like the current ratio is problematic, if Julien's
4/20 is representative. I started counting on a random pattern, and got
1/9 so far (slowed down by Salsa being down right now).
I like Julien's suggestion of just checking the total license length <20
or similar; but, I guess the best way to evaluate that change would be
to see how it would classify the 317 copyright files that are currently
flagged.
I'll see whether I can easily check that.
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Jonathan Dowland
⢿⡄⠘⠷⠚⠋⠀ https://jmtd.net
⠈⠳⣄⠀⠀⠀⠀
Reply to: