[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#886036: marked as done (Improve changelog version parsing)

Your message dated Sun, 26 Aug 2018 09:33:59 +0000
with message-id <E1ftrQl-000BFZ-Uc@fasolo.debian.org>
and subject line Bug#906957: fixed in lintian 2.5.98
has caused the Debian Bug report #906957,
regarding Improve changelog version parsing
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
906957: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=906957
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.5.67
Severity: wishlist
Tags: patch

Hi,

The attached patch set improves the version parsing in changelog. The
patches are annotated, but I also copied brief descriptions below.

The patches apply to the 2.5.68 master—one after the other, and
ordered in likelihood of acceptance. Thank you!

Best regards,
Felix

0001:
c/changelog-file: Fix version parsing for hyphen in upstream version
This patch fixes an issue when the upstream version contains a hyphen.
While the presence of a hyphen may not be desirable, it is okay
according to policy. This patch is superseded by another more elegant
patch later in the series.

0002:
c/cruft: Fix version parsing for native packages
This patch improves version parsing for native packages. It removes an
outdated pattern for non-maintainer uploads. The patch is superseded
by another patch later in the series.

0003:
c/source-changelog: Add version parsing
This patch adds version parsing to checks/source-changelog, where it
may be more appropriate than in the various places it is presently.
The parsing employs a somewhat long but hopefully correct regular
expression.

0004:
c/cruft: Transfer native and non-native version checking to c/source-changelog
This patch transfers two checks for version strings from checks/cruft
to checks/source-changelog, where they may a better home. The original
author also thought they did not belong in their original place. That
deficiency is now cured.

0005:
c/source-changelog: Add version info to native and non-native tag output
This patch prints the offending version string when the tags
'native-package-with-dash-version' or
'non-native-package-with-native-version' are emitted. Perhaps it helps
the user.

0006:
c/source-changelog: Add tag for hyphens in upstream versions
This patch adds a new tag 'hyphen-in-upstream-version' to warn about
the legal but occasionally perilous presence of hyphens in version
strings. It was the original motivation behind this patch series. I
had accidentally uploaded a package with such a version and tried to
work on it with Debian tools for shared libraries (dpkg-gensymbols or
its KDE cousin). I would like to see such a warning in the future, if
possible.

0007:
c/source-changelog: Rename tag 'native-package-with-dash-version' to
'hyphen-in-native-version'
This patch renames the tag 'native-package-with-dash-version' to
'hyphen-in-native-version'. The tag is totally related to
'hyphen-in-upstream-version' and deserves a less crufty and perhaps
less cryptic name.

0008:
c/source-changelog: Rename tag
'non-native-package-with-native-version' to
'debian-changelog-missing-debian-revision'
This patch renames the tag 'non-native-package-with-native-version' to
'debian-changelog-missing-debian-revision'. It is an attempt to add
clarity and userfriendliness to the name.


 checks/changelog-file.pm                 |  8 +++---
 checks/cruft.desc                        | 35 ------------------------
 checks/cruft.pm                          | 14 ----------
 checks/source-changelog.desc             | 46 ++++++++++++++++++++++++++++++++
 checks/source-changelog.pm               | 38 ++++++++++++++++++++++++++
 t/tests/changelog-file-experimental/tags |  2 +-
 t/tests/changelog-file-general/desc      |  8 +++++-
 t/tests/changelog-file-general/tags      |  1 +
 t/tests/cruft-native-dash-version/desc   |  3 ++-
 t/tests/cruft-native-dash-version/tags   |  2 +-
 t/tests/cruft-non-native-version/desc    |  3 ++-
 t/tests/cruft-non-native-version/tags    |  2 +-
 t/tests/legacy-binary/desc               |  2 +-
 t/tests/legacy-binary/tags               |  2 +-
 t/tests/legacy-fields/desc               |  2 +-
 t/tests/legacy-fields/tags               |  2 +-
 t/tests/legacy-filenames/tags            |  1 +
 t/tests/legacy-libbaz/desc               |  2 +-
 t/tests/legacy-libbaz/tags               |  2 +-
 t/tests/legacy-maintainer-scripts/tags   |  1 +
 20 files changed, 111 insertions(+), 65 deletions(-)

-- 
2.15.1

Attachment: improve-changelog-version-parsing.tar.xz
Description: application/xz


--- End Message ---
--- Begin Message --- 
Source: lintian
Source-Version: 2.5.98

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 906957@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 26 Aug 2018 09:00:19 +0000
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.98
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 lintian    - Debian package checker
Closes: 906722 906957 907261 907276
Changes:
 lintian (2.5.98) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - debian-rules-passes-version-info-to-dh_shlibdeps
       - multi-arch-same-package-calls-pycompile
 .
 .
   * checks/rules.pm:
     + [CL] Apply patch from Peter Pentchev to fix false-positives for
       missing Build-Depends on debhelper when using debhelper-compat
       commands.  (Closes: #907261)
   * checks/scripts.{desc,pm}:
     + [CL] Warn about Multi-Arch: same packages that use pycompile or
       py3compile in their maintainer scripts.  (Closes: #907276)
     + [CL] Expand the description to explain why we emit
       wrong-path-for-interpreter for #!/usr/bin/env perl.
   * checks/source-changelog.pm:
     + [FL] Fix false positives in version parsing, especially
       when some components are "0".  (Closes: #906957)
 .
   * data/rules/rules-should-not-use:
     + [CL] Check for packages that pass -V to dh_shlibdeps instead of
       dh_makeshlibs.  (Closes: #906722)
   * data/standards-version/release-dates:
     + [CL] Add 4.2.1 as a known Standards-Version.
Checksums-Sha1:
 b1b53ba6aef6f8fa9e7431bf31a4a5a247447784 3511 lintian_2.5.98.dsc
 4e576a9764f2bc95ba8127ecb7f3c9c4bb7f42c5 1582504 lintian_2.5.98.tar.xz
 85d0fb3ac0de1b81050294ccea24ad1693485571 1131024 lintian_2.5.98_all.deb
 4d96e61ef6247baed7a254aee69ba687edb7d252 16216 lintian_2.5.98_amd64.buildinfo
Checksums-Sha256:
 3db6b5b29cba2bf18fdff008a9377f877f616bae927af9e80da5b0bbcbfa11e9 3511 lintian_2.5.98.dsc
 7b230277923cf5db1f2e9e20f736fce441edc76f3d583886aaadccf744b808a2 1582504 lintian_2.5.98.tar.xz
 003a2e364910b81eeb146de2ebe35fc41c854d8d4ed244c4907c44ae65306f1e 1131024 lintian_2.5.98_all.deb
 fd2b6caab137cb475b1bd043927e3b7bd20f7676cb0cb488d5214b97ed8fcd74 16216 lintian_2.5.98_amd64.buildinfo
Files:
 82b8e3563053f96a6a2d7d6b32679578 3511 devel optional lintian_2.5.98.dsc
 a8ba0d745af7e779ebbcfe0dc9d77482 1582504 devel optional lintian_2.5.98.tar.xz
 a22d2aa600fd89744b17da5340caf1ea 1131024 devel optional lintian_2.5.98_all.deb
 7bc741e57898cb2f059ff05f26131bcb 16216 devel optional lintian_2.5.98_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAluCcq0ACgkQHpU+J9Qx
HlhtDw/9HUNs0u+YrcwoUzjG6lt6hqKHsFcSYJIsvbBjOIso4zaGw0MAtERRWXlz
MDn2fx1cJsKszEjS3yEBEXQluf7QoLxQMiMNnGFZV9qr7pwAfWhU3oLfQ4HAIVqZ
PuAkamTyVI+RDoBDankPyBbVK1E0ZoXhsPHwD31ARWGMpnsZPsm+5X+rXczsYkgT
HlibdvDep5OfebDXw2EWnY7HmP6vzZLcJu8eNFM9f4ckmXYoLU4MfREJBhhGtw4w
9MOOynWMLHm2MCW+vUe56Kgu27f/5zgV29QRy3jg+5TYjkxv8ziCy6whlHQT9Dnl
coD6KZokkLRmd5WuDzG9rwO5dSAS3106rrVEncmhLMQtlQyo2jZgX0k57K0YQvqC
/vyzithgpYtH6oFJcXRZIgkozKMaA2LsxuWxQOlZKJ0X2G9lTP2XsNMZgZmPlDG2
TrDV0RDE+TkTyhms80TtyEsRqT8D1Xwl1lj1e52RTQ0aU3Gv1i55okcaWcQsBfX3
MODVWJb3xka94+u3Yq1dwLrXTP3gjBtWNbMwk70CNSx4istubE2lAZdLUfiJbzH/
iApBhEnzKULw/s7MVnR98Z7unvVqjvN1B0jetdXay4VrkbrST0R9iicFeOt2xB1j
IyqjCJZczgurHWGrYNMYaM5A111s+6cTeBkqqn3J77pAbQuThkk=
=RsSx
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: