Bug#897157: lintian: Allow /usr/share/doc/$pkg/examples to be a symlink

[Rafael Laboissière <rafael@debian.org>]

Package: lintian
Version: 2.5.84
Severity: normal
Tags: patch

There are legitimate cases where /usr/share/doc/$pkg/examples is a 
symlink instead of a directory.  The code in checks/cruft.pm fails to 
detect that and issues a package-does-not-install-examples warning.

The patch attached below is a simplistic way to fix the problem.  Note 
that it does not allow to distinguishing between the cases where examples 
is a regular file or a symlink.  A more elaborated test should be done 
for coping with that.

Best,

Rafael Laboissière

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (650, 'testing'), (600, 'unstable'), (550, 'experimental'), (550, 'stable'), (500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils                          2.30-15
ii  bzip2                             1.0.6-8.1
ii  diffstat                          1.61-1+b1
ii  dpkg                              1.19.0.5
ii  file                              1:5.32-1
ii  gettext                           0.19.8.1-4
ii  intltool-debian                   0.35.0+20060710.4
ii  libapt-pkg-perl                   0.1.33
ii  libarchive-zip-perl               1.59-1
ii  libclass-accessor-perl            0.51-1
ii  libclone-perl                     0.39-1
ii  libdpkg-perl                      1.19.0.5
ii  libemail-valid-perl               1.202-1
ii  libfile-basedir-perl              0.07-1
ii  libipc-run-perl                   0.96-1
ii  liblist-moreutils-perl            0.416-1+b3
ii  libparse-debianchangelog-perl     1.2.0-12
ii  libperl5.24 [libdigest-sha-perl]  5.24.1-3+deb9u2
ii  libperl5.26 [libdigest-sha-perl]  5.26.1-6
ii  libtext-levenshtein-perl          0.13-1
ii  libtimedate-perl                  2.3000-2
ii  liburi-perl                       1.72-2
ii  libxml-simple-perl                2.24-1
ii  libyaml-libyaml-perl              0.63-2+b2
ii  man-db                            2.7.6.1-4
ii  patchutils                        0.3.4-2
ii  perl                              5.26.1-6
ii  t1utils                           1.41-2
ii  xz-utils                          5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b4

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  dpkg-dev               1.19.0.5
ii  libhtml-parser-perl    3.72-3+b2
ii  libtext-template-perl  1.47-1

-- no debconf information

diff --git a/checks/cruft.pm b/checks/cruft.pm
index b59f90cb2..5e91fa297 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -1585,7 +1585,7 @@ sub _ships_examples {
         return 1 if $name =~ m{-examples$};
         my @files = $binpkg->info->sorted_index;
         return 1
-          if any { m{^usr/share/doc/(.+/)?examples/$} } @files;
+          if any { m{^usr/share/doc/(.+/)?examples/?$} } @files;
     }
     return;
 }