[lintian] 01/01: Also check for chmod calls, not just chown for find(1) for maintainer-script-should-not-use-recursive-chown-or-chmod. (re. #895370)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 5b3351ed335e782f602ef276e906849bd401113b
Author: Chris Lamb <lamby@debian.org>
Date: Tue Apr 10 19:49:57 2018 +0100
Also check for chmod calls, not just chown for find(1) for maintainer-script-should-not-use-recursive-chown-or-chmod. (re. #895370)
---
data/scripts/maintainer-script-bad-command | 2 +-
debian/changelog | 4 ++--
t/tests/scripts-maintainer-general/debian/debian/postinst | 1 +
t/tests/scripts-maintainer-general/tags | 1 +
4 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/data/scripts/maintainer-script-bad-command b/data/scripts/maintainer-script-bad-command
index 6c2b606..1852a97 100644
--- a/data/scripts/maintainer-script-bad-command
+++ b/data/scripts/maintainer-script-bad-command
@@ -35,7 +35,7 @@ maintainer-script-should-not-use-dpkg-status-directly ~~ 1 ~~^(base-fi
maintainer-script-should-not-use-fc-cache ~~ 0 ~~^(fontconfig)$ ~~ ~~${LEADIN}(?:/usr/bin/)?fc-cache(?:\s|\Z)
maintainer-script-should-not-use-gconftool ~~ 1 ~~^(gconf\d)$ ~~ ~~(?:/usr/bin/)?gconftool(?:-\d)?(?:\s|\Z)
maintainer-script-should-not-use-install-sgmlcatalog ~~ 1 ~~ ~~ ~~\binstall-sgmlcatalog\b
-maintainer-script-should-not-use-recursive-chown-or-chmod ~~ 1 ~~ ~~ ~~\b(?:(?:chmod|chown).*(?:-R|--recursive)|find.*exec.*chown)\b
+maintainer-script-should-not-use-recursive-chown-or-chmod ~~ 1 ~~ ~~ ~~\b(?:(?:chmod|chown).*(?:-R|--recursive)|find.*exec.*(?:chmod|chown))\b
maintainer-script-should-not-use-service ~~ 1 ~~ ~~ ~~${LEADIN}service\b
maintainer-script-should-not-use-start-stop-daemon ~~ 0 ~~ ~~ ~~\bstart-stop-daemon(?=\s)(?!.*\s--stop\b)
maintainer-script-should-not-use-update-alternatives-remove ~~ 1 ~~ ~~^postrm$ ~~\b update\-alternatives\s+\-\-remove\b
diff --git a/debian/changelog b/debian/changelog
index e6a1d92..c3f2c05 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -26,8 +26,8 @@ lintian (2.5.82) UNRELEASED; urgency=medium
* data/scripts/maintainer-script-bad-command:
+ [CL] Also check for find(1) calls when checking for maintainer
- scripts that use a recursive chown. Thanks to Daniel Kahn Gillmor
- for the report. (Closes: #895370)
+ scripts that use a recursive chmod or chown. Thanks to Daniel Kahn
+ Gillmor for the report. (Closes: #895370)
* vendors/pureos/main/data/changes-file/derivative-versions:
+ [CL] Ensure that PureOS packages always end with (eg. pureosX).
diff --git a/t/tests/scripts-maintainer-general/debian/debian/postinst b/t/tests/scripts-maintainer-general/debian/debian/postinst
index 02c4a6b..f5d5803 100755
--- a/t/tests/scripts-maintainer-general/debian/debian/postinst
+++ b/t/tests/scripts-maintainer-general/debian/debian/postinst
@@ -217,5 +217,6 @@ chmod 777 -R /bad
chmod 777 --recursive /bad
chmod --recursive 777 /bad
find /bad -maxdepth 2 -type d -exec chown root:root {} \; # (#895370)
+find /bad -maxdepth 2 -type d -exec chmod 777 # (#895370)
#DEBHELPER#
diff --git a/t/tests/scripts-maintainer-general/tags b/t/tests/scripts-maintainer-general/tags
index 6beaeae..51e5cf3 100644
--- a/t/tests/scripts-maintainer-general/tags
+++ b/t/tests/scripts-maintainer-general/tags
@@ -50,6 +50,7 @@ W: scripts-maintainer-general: maintainer-script-should-not-use-recursive-chown-
W: scripts-maintainer-general: maintainer-script-should-not-use-recursive-chown-or-chmod postinst:217
W: scripts-maintainer-general: maintainer-script-should-not-use-recursive-chown-or-chmod postinst:218
W: scripts-maintainer-general: maintainer-script-should-not-use-recursive-chown-or-chmod postinst:219
+W: scripts-maintainer-general: maintainer-script-should-not-use-recursive-chown-or-chmod postinst:220
W: scripts-maintainer-general: maintainer-script-should-not-use-recursive-chown-or-chmod postinst:84
W: scripts-maintainer-general: maintainer-script-should-not-use-start-stop-daemon postinst:138
W: scripts-maintainer-general: maintainer-script-should-not-use-start-stop-daemon postinst:78
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: