[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: Avoid false-positives in Mallard XML files; <link href="..."> tags are anchor elements and not followed automatically. (Closes: #894690)



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit b3fd60aa18eebbe9db8455e4a31dbdb3e64541d6
Author: Chris Lamb <lamby@debian.org>
Date:   Tue Apr 3 22:18:09 2018 +0100

    Avoid false-positives in Mallard XML files; <link href="..."> tags are anchor elements and not followed automatically. (Closes: #894690)
---
 checks/files.pm                                    |  9 +++
 debian/changelog                                   |  3 +
 .../mallard-falsepositive.xml                      | 64 ++++++++++++++++++++++
 3 files changed, 76 insertions(+)

diff --git a/checks/files.pm b/checks/files.pm
index 67ec724..4f7d909 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -2092,6 +2092,15 @@ sub _check_tag_url_privacy_breach {
         return;
     }
 
+    # In Mallard XML, <link> is a clickable anchor that will not be
+    # followed automatically.
+    if(    $file->basename =~ '.xml$'
+        && $tagattr eq 'link'
+        && $file->file_contents
+        =~ qr{ xmlns="http://projectmallard\.org/1\.0/"}) {
+        return;
+    }
+
     # track well known site
     foreach my $breaker ($PRIVACY_BREAKER_WEBSITES->all) {
         my $value = $PRIVACY_BREAKER_WEBSITES->value($breaker);
diff --git a/debian/changelog b/debian/changelog
index 4c69553..302dc51 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -20,6 +20,9 @@ lintian (2.5.81) UNRELEASED; urgency=medium
     + [CL] Add .ogg files to the list of non-license file extensions to
       avoid a false-positive in extra-license-file. Thanks to Innocent De
       Marchi for the report.  (Closes: #894139)
+    + [CL] Avoid false-positives in Mallard XML files; <link href="...">
+      tags are anchor element and not followed automatically. Thanks to
+      Simon McVittie for the report.  (Closes: #894690)
   * checks/udev.pm:
     + [CL] Apply patch from Thomas Dallmair to avoid false positives in the
       udev-rule-missing-subsystem tag when SUBSYSTEM GOTO is not the last
diff --git a/t/tests/files-privacybreach/debian/src/privacy-breach-generic/mallard-falsepositive.xml b/t/tests/files-privacybreach/debian/src/privacy-breach-generic/mallard-falsepositive.xml
new file mode 100644
index 0000000..86ada9b
--- /dev/null
+++ b/t/tests/files-privacybreach/debian/src/privacy-breach-generic/mallard-falsepositive.xml
@@ -0,0 +1,64 @@
+<info xmlns="http://projectmallard.org/1.0/";>
+
+<item><p>Sender:</p>
+<p>The sender's email address or the name of the sender.</p></item>
+
+<item><p>Recipients:</p>
+<p>The recipients of the message.</p></item>
+
+<item><p>CC:</p>
+<p>Only the CC recipients of the message.</p></item>
+
+<item><p>BCC:</p>
+<p>Only the BCC recipients of the message. Obviously this can only be applied to outgoing filters.</p></item>
+
+<item><p>Sender or Recipients:</p>
+<p>The sender's email address or the name of the sender or the recipients of the message.</p></item>
+
+<item><p>Subject:</p>
+<p>The subject line of the message.</p></item>
+
+<item><p>Specific Header:</p>
+<p>Any header including <link xref="mail-composer-custom-header-lines">custom ones</link>.</p>
+<p>If a message uses a header more than once, <app>Evolution</app> pays attention only to the first instance, even if the message defines the header differently the second time. For example, if a message declares the Resent-From: header as "engineering@example.com" and then restates it as "marketing@example.com", <app>Evolution</app> filters as though the second declaration did not occur. To filter on messages that use headers multiple times, use a regular expression.</p></item>
+
+<item><p>Message Body:</p>
+<p>Searches in the actual text of the message.</p></item>
+
+<item><p>Expression:</p>
+<p>(For programmers only) Match a message according to an expression you write in the Scheme language used to define <link xref="mail-filters">filters</link> in <app>Evolution</app>.</p></item>
+
+<item><p>Free Form Expression:</p>
+<p>(For advanced users only) Combine numerous conditions by using a <link href="https://bugzilla.gnome.org/show_bug.cgi?id=550796#c10";>special syntax</link>.</p></item>
+
+<item><p>Date sent:</p>
+<p>Filters messages according to the date on which they were sent. First, choose the conditions you want a message to meet, such as before a given date or after a given date. Then choose the time. The filter compares the message's time stamp to the system clock when the filter is run, or to a specific time and date you choose from a calendar. You can also have it look for a message within a range of time relative to the filter, such as two to four days ago.</p></item>
+
+<item><p>Date received:</p>
+<p>This works the same way as the Date Sent option, except that it compares the time you received the message with the dates you specify.</p></item>
+
+<item><p>Label:</p>
+<p>Messages can have <link xref="mail-labels">labels</link> of Important, Work, Personal, To Do, or Later. You can set labels with other filters or manually.</p></item>
+
+<item><p>Score:</p>
+<p>Sets the message score to any whole number greater than 0. You can have one filter set or change a message score, and then set up another filter to move the messages you have scored. A message score is not based on anything in particular: it is simply a number you can assign to messages so other filters can process them.</p></item>
+
+<item><p>Size (kB):</p>
+<p>Sorts based on the size of the message in kilobytes.</p></item>
+
+<item><p>Status:</p>
+<p>Filters according to the status of a message. The status can be Replied To, Draft, Important, Read, or Junk.</p></item>
+
+<item><p>Follow Up:</p>
+<p>Checks whether the message is <link xref="mail-follow-up-flag">flagged for follow-up</link> or completed (after a certain date).</p></item>
+
+<item><p>Attachments:</p>
+<p>Checks whether there is an attachment for the email.</p></item>
+
+<item><p>Mailing List:</p>
+<p>Filters based on the mailing list the message came from. This filter might miss messages from some list servers, because it checks for the X-BeenThere header, which is used to identify mailing lists or other redistributors of mail. Mail from list servers that do not set X-BeenThere properly are not be caught by these filters.</p></item>
+
+<item><p>Regex Match:</p>
+<p>(For programmers only) If you know your way around a <link href="https://en.wikipedia.org/wiki/Regular_expression";>regex</link>, or regular expression, this option allows you to search for complex patterns of letters, so that you can find, for example, all words that start with "a" and end with "m", and are between six and fifteen letters long, or all messages that declare a particular header twice. For information about how to use regular expressions, check <link href="man:grep">the  [...]
+
+</info>

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: