[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#890537: marked as done (lintian: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS false positives)



Your message dated Wed, 21 Feb 2018 19:35:03 +0000
with message-id <E1eoaAR-0000S4-VA@fasolo.debian.org>
and subject line Bug#890537: fixed in lintian 2.5.76
has caused the Debian Bug report #890537,
regarding lintian: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS false positives
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
890537: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890537
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.5.75
Severity: minor

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

I went through some packages on 
https://lintian.debian.org/tags/override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS.html
and noted the following false positives:

libcgi-application-plugin-config-simple-perl 1.01-2

     6	override_dh_auto_test:
     7		cp t/test.ini test.ini.bak
     8		dh_auto_test
     9		mv test.ini.bak t/test.ini


libconfig-identity-perl 0.0019-1

    10	override_dh_auto_test:
    11		[ ! -e $(CURDIR)/t/assets/gpg/random_seed ] || cp -v $(CURDIR)/t/assets/gpg/random_seed $(CURDIR)/t/assets/gpg/random_seed.save
    12		CI_GPG=/usr/bin/gpg1 dh_auto_test


libdist-zilla-plugin-git-perl 2.043-1

    13	override_dh_auto_test:
    14		GIT_AUTHOR_EMAIL="pkg-perl-maintainers@lists.alioth.debian.org" \
    15		GIT_AUTHOR_NAME="Debian Perl Group" \
    16		dh_auto_test -- TEST_FILES="$(TEST_FILES)"


libfeed-find-perl 0.07-1

     6	override_dh_auto_test:
     7		[ ! -e inc/Spiffy.pm ] || mv inc/Spiffy.pm inc/Spiffy.pm-dontuse
     8		[ ! -e inc/Test ] || mv inc/Test inc/Test-dontuse
     9		NO_NETWORK=1 dh_auto_test
    10		[ ! -e inc/Spiffy.pm-dontuse ] || mv inc/Spiffy.pm-dontuse inc/Spiffy.pm
    11		[ ! -e inc/Test-dontuse ] || mv inc/Test-dontuse inc/Test


libgnupg-interface-perl 0.52-9

    12	override_dh_auto_test:
    13		mkdir -p $(BUILDHOME)
    14		# this chmod can be dropped once CPAN #102651 is resolved upstream
    15		chmod a+x test/fake-pinentry.pl
    16		HOME=$(BUILDHOME) dh_auto_test


libgnupg-perl 0.19-3

     6	override_dh_auto_test:
     7		cp -r $(CURDIR)/test $(CURDIR)/test.ori
     8		cp $(CURDIR)/debian/keyring/* $(CURDIR)/test/
     9		dh_auto_test
    10		rm -r $(CURDIR)/test && mv $(CURDIR)/test.ori $(CURDIR)/test


libhttp-daemon-ssl-perl 1.05-01-1

    18	override_dh_auto_test:
    19		test -e t/post.t && mv t/post.t t/testpost.t || :
    20		dh_auto_test
    21		mv t/testpost.t t/post.t


libmail-gnupg-perl 0.23-2

    12	override_dh_auto_test:
    13		chmod a+x t/fake-pinentry.pl
    14		dh_auto_test -- --test_files="$(TEST_FILES)"


libmodule-info-perl 0.37-1

     6	override_dh_auto_test:
     7		mv t/lib/Test t/lib/Test.ori
     8		dh_auto_test
     9		mv t/lib/Test.ori t/lib/Test


libmojolicious-perl 7.61+dfsg-1

     6	override_dh_auto_test:
     7		mkdir blib/lib/Mojolicious/resources/public/mojo/jquery
     8		ln -s /usr/share/javascript/jquery/jquery.js blib/lib/Mojolicious/resources/public/mojo/jquery
     9		ln -s /usr/share/javascript/prettify/run_prettify.js blib/lib/Mojolicious/resources/public/mojo/prettify
    10		dh_auto_test
    11		rm    blib/lib/Mojolicious/resources/public/mojo/prettify/run_prettify.js
    12		rm    blib/lib/Mojolicious/resources/public/mojo/jquery/jquery.js
    13		rmdir blib/lib/Mojolicious/resources/public/mojo/jquery


libopenoffice-oodoc-perl 2.125-3

    12	override_dh_auto_test:
    13		rm -f blib/lib/OpenOffice/OODoc/config.xml
    14		dh_auto_test


libpar-packer-perl 1.041-2

    20	override_dh_auto_test:
    21		ln -sf par.pl blib/script/par-archive
    22		dh_auto_test
    23		rm blib/script/par-archive


libpdl-graphics-gnuplot-perl 2.011-2

    11	override_dh_auto_test:
    12		true


libpoe-loop-event-perl 1.305-1

     6	override_dh_auto_test:
     7		perl -MNet::Ping -e '(Net::Ping->new()->ping("127.0.0.1", 1)) ? \
     8			system("touch run_network_tests") : system("rm -rf run_network_tests");'
     9		dh_auto_test


libpoe-loop-tk-perl 1.305-1
     6	override_dh_auto_test:
     7		perl -MNet::Ping -e '(Net::Ping->new()->ping("127.0.0.1", 1)) ? \
     8			system("touch run_network_tests") : system("rm -rf run_network_tests");'
     9		xvfb-run -a dh_auto_test


libwx-perl-datawalker-perl 0.02-1

     6	CMD=$(shell echo $@ | sed 's/override_//')
     7	
     8	override_dh_auto_test:
     9		xvfb-run -a $(CMD)


While some of these constructs are not beautiful, and many do useless
things if dh_auto_test just exits, I think none of them runs the
test suite or leads to build failures or has any side effects.


On the plus side, I also found 5 real errors on the page and 2
ugly-enough-to-fix-as-well cases :)


Cheers,
gregor


-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAlqF1yhfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgb67w//ayAsyLkeqiY6dHWipVmiys3xEaWEjNizoofFRsENlRuzf8Nhicyw6Sct
Fkqt1Ih7eGvPAvuYl8Nz/8emILEocydDql6j9P8b8ali/pEAV+ruia5TKiSwfG5C
AQH9wuf3fMSYYKFxbLotvORTdzOhF/QFRhagrrZPgxIBRiyKiBC9ASZIQyY1TU0p
dnwTZnf0ythRL3pEV1W38cCXyszY+cpPQR4+TJrVJQIvVJbr0AZoszC/pGiBNMqh
YCx1ovGtzneBwQYusnIl5d4h0cGwB+s/8mYMONlpClXSKJjHjsHqjgTKTRnjNP9x
xmWUay50pPy1ib/qVu9r4hJqoMR0spnHBo54kJf/3xl35WFjR+dsipD+Cn639R8b
9U+4EKmTsRkUICtCDk5IM/Yyokw2I5h4D3FXfnYhSfQuJ66sNnlYauf51F2jVKCU
y2ZHMJSvjjEYG/kZCTp1pdHDhCXIhAdjdVp3F+iHKEl22RZl8gTxdFynmgUx/oNL
I8AoSj/WB7ZAshnjLlhirtYLEI9gG/T5QQ8GGdhk5QS4+LhqkdK5lwmHlDSCRtJj
QmYUNLwSxdN4OiJNadPz6iNwyVW3EYpEevP7NgxzDSgFxaP1xqR/Ea1fEQJlXPq4
t/Kyl+aSgkRRuGtctOZfCLx7iE1zoV9YDMmwUAfHhHcXZp83h78=
=M1rc
-----END PGP SIGNATURE-----

--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.5.76

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 890537@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 21 Feb 2018 18:42:26 +0000
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.76
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 lintian    - Debian package checker
Closes: 832099 833007 890530 890537 890660 890667 890916 890920 890943 890959 891027
Changes:
 lintian (2.5.76) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - debhelper-compat-file-contains-multiple-levels
       - debian-changelog-line-too-short
       - unnecessary-source-date-epoch-assignment
       - upstream-metadata-file-is-missing
     + Renamed:
       - co-maintained-package-with-no-vcs-headers ->
         co-maintained-package-with-no-vcs-fields.
       - desktop-contains-deprecated-header ->
         desktop-contains-deprecated-key.
       - xs-testsuite-header-in-debian-control ->
         xs-testsuite-field-in-debian-control.
       - unnecessary-testsuite-autopkgtest-header ->
         unnecessary-testsuite-autopkgtest-field.
       - xs-vcs-header-in-debian-control ->
         xs-vcs-field-in-debian-control.
 .
   * General:
     + [CL] Apply a patch series from Ben Finney to correct inconsistent use
       of "header" terminology (versus "field", etc.) in descriptions and
       tag names.  Thanks!  (Closes: #890959)
 .
   * checks/changelog-file.{desc,pm}:
     + [CL] Warn about changelog files that are too short.  Thanks to Adrian
       Bunk for the suggestion.  (Closes: #890920)
   * checks/cruft.pm:
     + [CL] Avoid false-positives in Jush's syntax highlighting definition
       files.
     + [CL] Avoid a false-positive when matching the fake Lena Söderberg
       image in libplacebo.  Thanks to Thorsten Alteholz for the report.
       (Closes: #890943)
   * checks/debhelper.{desc,pm}:
     + [CL] Warn if packages define multiple compatibility levels in the
       "compat" file, typically via "echo 11 >> debian/compat" (instead of
       ">").
   * checks/fields.desc:
     + [CL] Correct a grammatical error and tighten up the language of the
       "binary-package-depends-on-toolchain-package" tag's description.
       Thanks to Gregor Herrmann for the report.  (Closes: #890530)
   * checks/init.d.pm:
     + [CL] Also check for "RUN=" and "DAEMONRUN=" when evalating lines in
       /etc/default for "init.d-script-should-always-start-service"
       violations. Thanks to Laurent Bigonville.  (Closes: #890916)
   * checks/rules.{desc,pm}:
     + [CL] Update override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
       to fix a number of false positives. Thanks to Gregor Herrmann for
       the report.  (Closes: #890537)
     + [CL] Also check, for example, "override_dh_fixperms-indep" and
       "override_dh_fixperms-arch" targets for
       "override_dh_fixperms-does-not-call-dh_fixperms", etc.
     + [CL] Prevent a large number of false-positives when checking the
       debian-rules-is-dh_make-template tag.  Thanks to Evgeni Golov for
       the report.  (Closes: #890660)
     + [CL] Check for unnecessary SOURCE_DATE_EPOCH assignments; it is
       either exported by dpkg >= 1.18.8 or one can include pkg-info.pk,
       etc.  (Closes: #832099)
   * checks/scripts.pm:
     + [CL] Prevent some false-positives in udevadm-called-without-guard.
   * checks/upstream-metadata.{desc,pm}:
     + [CL] Apply patch from Dylan Aïssi to suggest maintainers add a
       debian/upstream/metadata file, although downgrade the check to
       "experimental" level for the time being.  (Closes: #833007)
   * checks/watch-file.pm:
     + [CL] Use our new $PKGREPACK_REGEX to match and capture the suffix
       when looking at potential debian/watch mangling issues.
 .
   * commands/reporting-html-reports.pm:
     + [NT] Stop including the uncompressed lintian log in the website
       as it consumes considerable space for no reason.  Consumers
       should migrate to the compressed variant, which has been around
       for years and only consumes ~1/20th of the space.
 .
   * data/files/python-generic-modules:
     + [CL] Detect "core" as an overly-generic module name.  Thanks to
       Andreas Beckmann for the report.  (Closes: #891027)
   * data/scripts/interpreters:
     + [CL] Add cwl-runner (to cwltool) as an interpreter for CWL scripts.
       Thanks to Michael Crusoe for the report.  (Closes: #890667)
   * data/spelling/corrections:
     + [PW] Add a number of corrections.
 .
   * debian/source/lintian-overrides:
     + [CL] Drop all the overrides for Lintian itself now that we use the
       <!nocheck> build profile for the previously-spurious warnings.
 .
   * lib/Lintian/Util.pm:
     + [CL] Factor out the regex that matches "repacked" tarballs based on
       their filename.
   * lib/Lintian/Collect/{Changes,Sources}.pm:
     + [CL] Add repacked subroutines to check whether a package has been
       repacked or not.
 .
   * reporting/templates/maintainer.tmpl:
     + [CL] Link package entries directly to sources.debian.org.
 .
   * t/scripts/changelog-format.t:
     + [CL] Provide some possibly-helpful advice when violating the "entry
       header" changelog test.
   * t/tests/cruft-upstream-binaries:
     + [CL] Add a testcase to check that symlinked missing-sources do the
       right thing (re. #890468).
Checksums-Sha1:
 bf9b3395b6467ffd1ce123a378071ccda28e997c 3505 lintian_2.5.76.dsc
 f039c2e8bf5acd73aea2f968e39c7d6e01f52326 1537236 lintian_2.5.76.tar.xz
 36cf5700e371114c9a5cf1cb1247a3f77f5b7dab 1105364 lintian_2.5.76_all.deb
 2c94f54be740fbb16a8bafb18657fdfb2b43777f 16053 lintian_2.5.76_amd64.buildinfo
Checksums-Sha256:
 660b3a52d696a33ff95ecd43b58e57681b70afe44a53e2984d1b616c9d662337 3505 lintian_2.5.76.dsc
 e7a12767b811c6072035691c940c7d0eaf64a986d6f074fe1ccd2caecb434f8b 1537236 lintian_2.5.76.tar.xz
 efbe81a0b506848b04404a0dad6009c85408a022b804d4f106613e0940d2f5ec 1105364 lintian_2.5.76_all.deb
 08029d7f2c9220f6df8131601a2c85bfc0768d7769cfceb86a138783e9f78eb0 16053 lintian_2.5.76_amd64.buildinfo
Files:
 a11ca1e7a6fa5e888243bc9757965f15 3505 devel optional lintian_2.5.76.dsc
 01e36a73587f63dcdfdd2fe13e7efebf 1537236 devel optional lintian_2.5.76.tar.xz
 11992858684eb467fc87e2495d564070 1105364 devel optional lintian_2.5.76_all.deb
 878f56d59e53196834e766a2cab95de4 16053 devel optional lintian_2.5.76_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlqNx+0ACgkQHpU+J9Qx
HljNjg//V1lPPIM9mEP49hE5f5UvGbj2VpJChWbQOGRmtwIqrdoZ/nu3kb4Ecl7+
J/qvcX5KZVl0DjboUluQf6OP9akSby01HudrObxFbMMMYG5VoAEGypgWnbiiJLqx
UfvgLr4Zo5w407ziEHLWyX60ONzcz0PwGwZox727PFByKNMvRL0lUkbRXykbOoGx
QgTfH0c74DCMt31j73mzDP9ZZ2UPDWoGYH5pOMS9QrDRtbKcZi08765xRS08Xnwr
ddkVa2xYwsNRwPd6Z1TGyQKYx6JP9u6SuepWA2c1ddHjusKSTVBCwfquygvTrBs6
C7HAVv1V2349YOczoA7nRrjUyKOkBT/d6O4h2AN2vGSD9I7GUgwTiStJqHZgv6sa
vqrVXO+L+o8LAaUi/GgYTJOSgUjwOC2U2GNIrh1sZ55n7DrVYmrf4DJjU2o4wfMl
vN9iBjpN3N2ij//V5KJfuylD9e760zYvL93RTeTuTqAcaxjEoxI1bCZqYgQTa29S
rYw/v8SGjo9hjeLaeemr7qmQgZm/HFF3MEpn0xzcal2T0CMC6OL3EoPnHbBf/RJZ
woatfZ7vK54ZSsZdVNWMtGinuLIBxxUOFCCfjzUZotr2xGcU7+ON0KtBUDp+zWJT
cClBUE77LOLRKiFYgnGMnBWUw1lKPg+zYl49nZ+OWagto+770wY=
=H+Ck
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: