[lintian] 01/01: Avoid a false-positive when matching the fake Lena Söderberg image in libplacebo. Thanks to Thorsten Alteholz for the report. (Closes: #890943)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit a39f095305a9adaa557d90c870d37aa6c126162d
Author: Chris Lamb <lamby@debian.org>
Date: Wed Feb 21 14:33:07 2018 +0000
Avoid a false-positive when matching the fake Lena Söderberg image in libplacebo. Thanks to Thorsten Alteholz for the report. (Closes: #890943)
---
checks/cruft.pm | 6 +++++-
data/cruft/lenna-whitelist | 4 ++++
debian/changelog | 3 +++
.../cruft-non-free-img/debian/data-fake-lenna-2.jpeg | Bin 0 -> 54038 bytes
4 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/checks/cruft.pm b/checks/cruft.pm
index 9e61cfe..fe67d49 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -154,6 +154,9 @@ my $RFC_WHITELIST = Lintian::Data->new(
return qr/$_[0]/xms;
});
+# "Known good" files that match eg. lena.jpg.
+my $LENNA_WHITELIST = Lintian::Data->new('cruft/lenna-whitelist');
+
# prebuilt-file or forbidden copyright
my $BAD_LINK_COPYRIGHT = Lintian::Data->new(
'cruft/bad-link-copyright',
@@ -707,7 +710,8 @@ sub find_cruft {
or $file_info =~ /\bbitmap\b/i
or $file_info =~ /^PDF Document\b/i
or $file_info =~ /^Postscript Document\b/i) {
- tag 'license-problem-non-free-img-lenna', $name;
+ tag 'license-problem-non-free-img-lenna', $name
+ unless $LENNA_WHITELIST->known($md5sum);
}
}
diff --git a/data/cruft/lenna-whitelist b/data/cruft/lenna-whitelist
new file mode 100644
index 0000000..2ca0315
--- /dev/null
+++ b/data/cruft/lenna-whitelist
@@ -0,0 +1,4 @@
+# md5sums of known-good Lenna images
+
+# libplacebo demos/lena.jpg
+0ea16a2c4b94f0c1a83d11278655ac9f
diff --git a/debian/changelog b/debian/changelog
index ae3831d..d4c317b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,9 @@ lintian (2.5.76) UNRELEASED; urgency=medium
* checks/cruft.pm:
+ [CL] Avoid false-positives in Jush's syntax highlighting definition
files.
+ + [CL] Avoid a false-positive when matching the fake Lena Söderberg
+ image in libplacebo. Thanks to Thorsten Alteholz for the report.
+ (Closes: #890943)
* checks/debhelper.{desc,pm}:
+ [CL] Warn if packages define multiple compatibility levels in the
"compat" file, typically via "echo 11 >> debian/compat" (instead of
diff --git a/t/tests/cruft-non-free-img/debian/data-fake-lenna-2.jpeg b/t/tests/cruft-non-free-img/debian/data-fake-lenna-2.jpeg
new file mode 100644
index 0000000..ddaae15
Binary files /dev/null and b/t/tests/cruft-non-free-img/debian/data-fake-lenna-2.jpeg differ
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: