[lintian] 02/02: Emit a pedantic warning for packages that are using the dpatch patch system. (Closes: #884500)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit c2194b556346247f37e28f75f1d76115b005dcce
Author: Chris Lamb <lamby@debian.org>
Date: Sun Jan 28 19:16:18 2018 +1100
Emit a pedantic warning for packages that are using the dpatch patch system. (Closes: #884500)
---
checks/patch-systems.desc | 10 ++++++++++
checks/patch-systems.pm | 1 +
debian/changelog | 3 +++
t/tests/patch-systems-dpatch-description/desc | 3 +++
t/tests/patch-systems-dpatch-description/tags | 1 +
5 files changed, 18 insertions(+)
diff --git a/checks/patch-systems.desc b/checks/patch-systems.desc
index 47301bc..e8f9b6f 100644
--- a/checks/patch-systems.desc
+++ b/checks/patch-systems.desc
@@ -208,3 +208,13 @@ Info: The specified patch is present under the <tt>debian/patches</tt>
.
0001_fix-foo.patch
# 0002_fix-bar.patch
+
+Tag: package-uses-deprecated-dpatch-patch-system
+Severity: pedantic
+Certainty: certain
+Info: The dpatch patch system has been deprecated and superceded by the
+ "3.0 (quilt)" source format.
+ .
+ Please migrate the patches in the <tt>debian/patches</tt> directory and
+ the <tt>00list</tt> file to use this source format.
+Ref: dpatch(1), dpkg-source(1)
diff --git a/checks/patch-systems.pm b/checks/patch-systems.pm
index fb2e629..134a650 100644
--- a/checks/patch-systems.pm
+++ b/checks/patch-systems.pm
@@ -60,6 +60,7 @@ sub run {
#----- dpatch
if ($build_deps->implies('dpatch')) {
my $list_file;
+ tag 'package-uses-deprecated-dpatch-patch-system';
$uses_patch_system++;
$list_file = $dpdir->resolve_path('00list') if $dpdir;
#check for a debian/patches file:
diff --git a/debian/changelog b/debian/changelog
index ec51588..f2c1d16 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,9 @@ lintian (2.5.73) UNRELEASED; urgency=medium
* checks/fields.{desc,pm}:
+ [CL] Add a pedantic warning for co-maintained packages that are not
managed in a revision control system. (Closes: #884497)
+ * checks/patch-systems.{desc,pm}:
+ + [CL] Emit a pedantic warning for packages that are using the dpatch
+ patch system. (Closes: #884500)
* checks/source-copyright.{desc,pm}:
+ [CL] Warn about packages that specify a Files-Excluded header without
a valid Format header as the former will be ignored by uscan(1).
diff --git a/t/tests/patch-systems-dpatch-description/desc b/t/tests/patch-systems-dpatch-description/desc
index 48e8ed0..f1c9de7 100644
--- a/t/tests/patch-systems-dpatch-description/desc
+++ b/t/tests/patch-systems-dpatch-description/desc
@@ -2,7 +2,10 @@ Testname: patch-systems-dpatch-description
Version: 1.0
Description: Test patch-system tags for a dpatch package
Extra-Build-Depends: dpatch
+Options: --pedantic -I
+Skeleton: pedantic
Test-For:
dpatch-index-references-non-existent-patch
dpatch-missing-description
+ package-uses-deprecated-dpatch-patch-system
patch-file-present-but-not-mentioned-in-series
diff --git a/t/tests/patch-systems-dpatch-description/tags b/t/tests/patch-systems-dpatch-description/tags
index d2e60e8..06f9751 100644
--- a/t/tests/patch-systems-dpatch-description/tags
+++ b/t/tests/patch-systems-dpatch-description/tags
@@ -3,4 +3,5 @@ E: patch-systems-dpatch-description source: dpatch-index-references-non-existent
E: patch-systems-dpatch-description source: dpatch-index-references-non-existent-patch 01_some_other_patch_thats_not_in_the_package.dpatch
I: patch-systems-dpatch-description source: dpatch-missing-description 02_i_dont_have_a_description.patch
I: patch-systems-dpatch-description source: dpatch-missing-description 04_i_dont_have_a_description_either.patch
+P: patch-systems-dpatch-description source: package-uses-deprecated-dpatch-patch-system
W: patch-systems-dpatch-description source: patch-file-present-but-not-mentioned-in-series 03_specified_without_dpatch.dpatch
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: