Bug#912912: lintian: please detect for loops without set -e

[Mattia Rizzolo <mattia@debian.org>]

Package: lintian
Severity: wishlist

See #912910 - I think these situations could easily be detected by
lintian, and marked with an E-tag when d/rules doesn't.

Reference: Policy §4.6


bad bad bad:
    for var in $(things_to_to_loop_on); do \
        $(whatever); \
    done

"good":
    set -e ; for var in $(things_to_to_loop_on); do \
        $(whatever); \
    done


Note however that the set -e could be omitted if one has

    SHELL=sh -e

or

    .SHELLFLAGS=-ec

or similar (even if *personally* I find using such means somewhat
obscure).

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature