Your message dated Sat, 18 Aug 2018 09:19:43 +0000 with message-id <E1fqxOZ-000FbS-Q9@fasolo.debian.org> and subject line Bug#886036: fixed in lintian 2.5.97 has caused the Debian Bug report #886036, regarding Improve changelog version parsing to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 886036: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886036 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: Improve changelog version parsing
- From: Felix Lechner <felix.lechner@lease-up.com>
- Date: Mon, 1 Jan 2018 13:15:22 -0800
- Message-id: <CAFHYt56YvwxMYkfAqapt_Hpwerri2zm87r1Jsx3K3-GJGPbh7g@mail.gmail.com>
Package: lintian Version: 2.5.67 Severity: wishlist Tags: patch Hi, The attached patch set improves the version parsing in changelog. The patches are annotated, but I also copied brief descriptions below. The patches apply to the 2.5.68 master—one after the other, and ordered in likelihood of acceptance. Thank you! Best regards, Felix 0001: c/changelog-file: Fix version parsing for hyphen in upstream version This patch fixes an issue when the upstream version contains a hyphen. While the presence of a hyphen may not be desirable, it is okay according to policy. This patch is superseded by another more elegant patch later in the series. 0002: c/cruft: Fix version parsing for native packages This patch improves version parsing for native packages. It removes an outdated pattern for non-maintainer uploads. The patch is superseded by another patch later in the series. 0003: c/source-changelog: Add version parsing This patch adds version parsing to checks/source-changelog, where it may be more appropriate than in the various places it is presently. The parsing employs a somewhat long but hopefully correct regular expression. 0004: c/cruft: Transfer native and non-native version checking to c/source-changelog This patch transfers two checks for version strings from checks/cruft to checks/source-changelog, where they may a better home. The original author also thought they did not belong in their original place. That deficiency is now cured. 0005: c/source-changelog: Add version info to native and non-native tag output This patch prints the offending version string when the tags 'native-package-with-dash-version' or 'non-native-package-with-native-version' are emitted. Perhaps it helps the user. 0006: c/source-changelog: Add tag for hyphens in upstream versions This patch adds a new tag 'hyphen-in-upstream-version' to warn about the legal but occasionally perilous presence of hyphens in version strings. It was the original motivation behind this patch series. I had accidentally uploaded a package with such a version and tried to work on it with Debian tools for shared libraries (dpkg-gensymbols or its KDE cousin). I would like to see such a warning in the future, if possible. 0007: c/source-changelog: Rename tag 'native-package-with-dash-version' to 'hyphen-in-native-version' This patch renames the tag 'native-package-with-dash-version' to 'hyphen-in-native-version'. The tag is totally related to 'hyphen-in-upstream-version' and deserves a less crufty and perhaps less cryptic name. 0008: c/source-changelog: Rename tag 'non-native-package-with-native-version' to 'debian-changelog-missing-debian-revision' This patch renames the tag 'non-native-package-with-native-version' to 'debian-changelog-missing-debian-revision'. It is an attempt to add clarity and userfriendliness to the name. checks/changelog-file.pm | 8 +++--- checks/cruft.desc | 35 ------------------------ checks/cruft.pm | 14 ---------- checks/source-changelog.desc | 46 ++++++++++++++++++++++++++++++++ checks/source-changelog.pm | 38 ++++++++++++++++++++++++++ t/tests/changelog-file-experimental/tags | 2 +- t/tests/changelog-file-general/desc | 8 +++++- t/tests/changelog-file-general/tags | 1 + t/tests/cruft-native-dash-version/desc | 3 ++- t/tests/cruft-native-dash-version/tags | 2 +- t/tests/cruft-non-native-version/desc | 3 ++- t/tests/cruft-non-native-version/tags | 2 +- t/tests/legacy-binary/desc | 2 +- t/tests/legacy-binary/tags | 2 +- t/tests/legacy-fields/desc | 2 +- t/tests/legacy-fields/tags | 2 +- t/tests/legacy-filenames/tags | 1 + t/tests/legacy-libbaz/desc | 2 +- t/tests/legacy-libbaz/tags | 2 +- t/tests/legacy-maintainer-scripts/tags | 1 + 20 files changed, 111 insertions(+), 65 deletions(-) -- 2.15.1Attachment: improve-changelog-version-parsing.tar.xz
Description: application/xz
--- End Message ---
--- Begin Message ---
- To: 886036-close@bugs.debian.org
- Subject: Bug#886036: fixed in lintian 2.5.97
- From: Chris Lamb <lamby@debian.org>
- Date: Sat, 18 Aug 2018 09:19:43 +0000
- Message-id: <E1fqxOZ-000FbS-Q9@fasolo.debian.org>
Source: lintian Source-Version: 2.5.97 We believe that the bug you reported is fixed in the latest version of lintian, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 886036@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Chris Lamb <lamby@debian.org> (supplier of updated lintian package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sat, 18 Aug 2018 08:47:03 +0000 Source: lintian Binary: lintian Architecture: source all Version: 2.5.97 Distribution: unstable Urgency: medium Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org> Changed-By: Chris Lamb <lamby@debian.org> Description: lintian - Debian package checker Closes: 886036 905843 905881 906155 Changes: lintian (2.5.97) unstable; urgency=medium . * Summary of tag changes: + Added: - debian-changelog-version-requires-debian-revision - maintainer-script-needs-depends-on-xfonts-utils - malformed-debian-changelog-version - missing-call-to-update-fonts - upload-has-backports-version-number + Renamed: - native-package-with-dash-version -> hyphen-in-native-debian-changelog-version - non-native-package-with-native-version -> hyphen-in-upstream-part-of-debian-changelog-version . * checks/changes-file.{desc,pm}: + [CL] Apply patch from Julien Cristau (with test) to warn about uploads that have a version containing "~bpo" but their target distribution is not *-backports. (Closes: #906155) * checks/scripts.{desc,pm}: + [CL] Check for packages that contain X11 fonts but do not run update-fonts-* in their postinst or depend on xfonts-utils. (Closes: #905881) * checks/source-changelog.{desc.pm}: + [FL] Rework, centralise and improve version parsing. (Closes: #886036) . * data/common/dh_addons: + [NT] Refresh data. * data/debhelper/dh_{commands,packages}: + [NT] Refresh data. * data/spelling/corrections: + [PW] Add a number of corrections. * data/testsuite/known-restrictions: + [CL] Re-add "allow-stderr" accidentally dropped in 0cb688fb. (Closes: #905843) . * private/refresh-debhelper-data: + [NT] Add debhelper-compat an alternative to debhelper in the data files. . * t/scripts/01-critic/runner.pl: + [CL] Bump perltidy test dependencies to prevent a failing build in backports, etc. Checksums-Sha1: 201a7700b55171b6409dcb51542127e76ed5989d 3511 lintian_2.5.97.dsc afca332adc396393daadfce5c4ca01aba59847dd 1581324 lintian_2.5.97.tar.xz 0ab775770eb022e1455dd2c4f38b949e31b875ca 1131112 lintian_2.5.97_all.deb 7ec67033ae22df38abafa4a50ffc492535f55169 16206 lintian_2.5.97_amd64.buildinfo Checksums-Sha256: 37f859952c2eb81ec43da848accb6ab471333c1f1e9f22f410c7f7d5a776a874 3511 lintian_2.5.97.dsc b6292b9d6f1fe903372a9da282675b710c20aacddb4787988c34a38a113fca5b 1581324 lintian_2.5.97.tar.xz 32abbd5c62d8d2a6b05b720d58c8345b7f5875376605f2edf44b5f9c24833908 1131112 lintian_2.5.97_all.deb efd69464d2c9cf412fd8242af269e36b088376732789c843d1d8a403833d9231 16206 lintian_2.5.97_amd64.buildinfo Files: d1abaff79bbfe8d823c426807cb2566e 3511 devel optional lintian_2.5.97.dsc cc0dd27d1426112f4ae549beffb53f9b 1581324 devel optional lintian_2.5.97.tar.xz 9cb5e6354daf0721dfc92a34d1c5a6f1 1131112 devel optional lintian_2.5.97_all.deb 896b4ea6e98543cf42c4b3432ab83055 16206 devel optional lintian_2.5.97_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlt34yUACgkQHpU+J9Qx HljG7w/+IhdEuAV5Q+LpEOj0qnHSlfNGYhKXKWhYJRULZIPX2+aEo0jqVYmfYV/N 3HwcAnJzOhc5sucUuXEHVg47bs0BQLFBz6n+TiNPian+29+OPDmdNHwHcGkfojIF bHz+rB3xobDfmGJKoylPRxmge9mHzRa+mGw9z7njMjshvq1DM7tbi6tfs348ZaHK MKTnw2PNnBQgYAA2Aykz4YOlYmlbT2rEhbgBYUt6y+p3Pxyi59JJcqw7+7T5TkyY tNS35lXFS7e3CZ87qeOz212gAtcyJcZt5QChuDUTSBYiOEz0FSmKXhKc1oP6YXjI +G180vdZyMljG0D+lhjIQ20Fob5SYMvWYPVt7PoKvS6BRN2n+24qMvt1i4xW+1Ou H+xaIxXT0txtofGmGsKLoSMWqfCG2N0TTTlmocXxnuB0gpbFpRTRl9gZWIsIbB8i 9OOG1zhN2u+5dZovvzr8qeP0kFe0uCkkRMH6JT8xk6RaKi5nEHG9rrD9qOV+ZzD4 5CTdsnfZjcayzIKhEFkIlnjWmmnVwvpMRBHHoQ7vPtV4z1lRyApvs9gONSsp7/nv MQut4wrRlsmCpFAjAJGOfcit1QCvHmF2d1Fwa0azBC+sX5ZlyyG2+R8Fm8RVpPB6 58QXKgw9J4800oip9OEaCGDBgOJuXGaxeX8ChblWwJ8ZP/9pJ+U= =goH4 -----END PGP SIGNATURE-----
--- End Message ---