Bug#899134: lintian: desktop file checks have outdated links
Package: lintian
Version: 2.5.86
Severity: normal
Tags: patch
The desktop file checks contain links to the spec. Some of these need to be
updated for the latest version of the spec. The attached patch fixes the
issues I found this morning.
Ross
>From d0c2fc81c847bb3015768c33820c3d21f9418aa9 Mon Sep 17 00:00:00 2001
From: Ross Vandegrift <ross@kallisti.us>
Date: Sat, 19 May 2018 10:01:04 -0700
Subject: [PATCH] Update freedesktop.org desktop spec links
Section page links have changed in the latest version of the desktop spec.
Also, s/standards/specifications/ to match the rest of lintian.
---
checks/menu-format.desc | 16 ++++++++--------
checks/menu-format.pm | 2 +-
data/menu-format/known-desktop-keys | 2 +-
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/checks/menu-format.desc b/checks/menu-format.desc
index b9027bf..9ae97ce 100644
--- a/checks/menu-format.desc
+++ b/checks/menu-format.desc
@@ -252,7 +252,7 @@ Info: The desktop entry file has lines ending in CRLF instead of just LF.
<tt>CR</tt> character in the file:
.
<tt>sed -i 's/\r//g' path/to/file</tt>
-Ref: https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s02.html
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s03.html
Tag: duplicated-key-in-desktop-entry
Severity: normal
@@ -270,7 +270,7 @@ Info: Desktop entries must contain, at a minimum, the keys Type and Name.
.
The desktop-file-validate tool in the desktop-file-utils package is
useful for checking the syntax of desktop entries.
-Ref: https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html
Tag: desktop-entry-contains-unknown-key
Severity: minor
@@ -282,7 +282,7 @@ Info: The key on this line of the desktop entry is not one of the standard
.
The desktop-file-validate tool in the desktop-file-utils package is
useful for checking the syntax of desktop entries.
-Ref: https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html
Tag: desktop-entry-contains-deprecated-key
Severity: normal
@@ -292,7 +292,7 @@ Info: The key on this line of the desktop entry has been deprecated in the
.
The desktop-file-validate tool in the desktop-file-utils package is
useful for checking the syntax of desktop entries.
-Ref: https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/apc.html
Tag: desktop-entry-contains-encoding-key
Severity: wishlist
@@ -304,7 +304,7 @@ Info: The Encoding key is now deprecated by the FreeDesktop standard and
.
The desktop-file-validate tool in the desktop-file-utils package is
useful for checking the syntax of desktop entries.
-Ref: https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/apc.html
Tag: desktop-entry-lacks-main-category
Severity: normal
@@ -329,7 +329,7 @@ Info: This .desktop file does not contain an "Icon" entry.
.
The desktop-file-validate tool in the desktop-file-utils package is
useful for checking the syntax of desktop entries.
-Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html,
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html,
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html,
#854132
@@ -346,7 +346,7 @@ Info: This .desktop file does either not contain a "Keywords" entry or it does
.
The desktop-file-validate tool in the desktop-file-utils package is
useful for checking the syntax of desktop entries.
-Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html,
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html,
#693918, https://wiki.gnome.org/Initiatives/GnomeGoals/DesktopFileKeywords
Tag: desktop-entry-uses-reserved-category
@@ -393,7 +393,7 @@ Info: The key on this line of the desktop entry has been deprecated in the
.
The desktop-file-validate tool in the desktop-file-utils package is
useful for checking the syntax of desktop entries.
-Ref: https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/apc.html
Tag: desktop-mime-but-no-exec-code
Severity: normal
diff --git a/checks/menu-format.pm b/checks/menu-format.pm
index 295079f..0edf43e 100644
--- a/checks/menu-format.pm
+++ b/checks/menu-format.pm
@@ -96,7 +96,7 @@ my $DEPRECATED_DESKTOP_KEYS
my $KDE_DESKTOP_KEYS = Lintian::Data->new('menu-format/kde-desktop-keys');
# Known types of desktop entries.
-# https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
+# https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html
my %known_desktop_types = map { $_ => 1 } qw(
Application
Link
diff --git a/data/menu-format/known-desktop-keys b/data/menu-format/known-desktop-keys
index 568cfba..01a520c 100644
--- a/data/menu-format/known-desktop-keys
+++ b/data/menu-format/known-desktop-keys
@@ -1,4 +1,4 @@
-# from https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
+# from https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html
# list of Recognized desktop entry keys
# please alpha sort
#
--
2.17.0
Reply to: