[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: Allow rel="generator" and others; they do not cause internet access by default. Thanks to Raphaël Hertzog for the report. (Closes: #891301)



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 617907370bbcbaf823de43032b37629a40faed0e
Author: Chris Lamb <lamby@debian.org>
Date:   Sat Feb 24 11:22:25 2018 +0000

    Allow rel="generator" and others; they do not cause internet access by default. Thanks to Raphaël Hertzog for the report. (Closes: #891301)
---
 checks/files.pm                                                  | 9 +++++++++
 debian/changelog                                                 | 4 ++++
 .../debian/src/privacy-breach-generic/link-generator.xml         | 2 ++
 3 files changed, 15 insertions(+)

diff --git a/checks/files.pm b/checks/files.pm
index 8f2ee62..6965538 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -2051,11 +2051,20 @@ sub _check_tag_url_privacy_breach {
                       >,xismog;
         my $relcontent = $1;
         if (defined($relcontent)) {
+            # See, for example, https://www.w3schools.com/tags/att_link_rel.asp
             my %allowed = (
+                'alternate'         => 1, # #891301
+                'author'            => 1, # #891301
                 'bookmark'          => 1, # #746656
                 'canonical'         => 1, # #762753
+                'generator'         => 1, # #891301
                 'generator-home'    => 1, # texinfo
+                'help'              => 1, # #891301
+                'license'           => 1, # #891301
+                'next'              => 1, # #891301
+                'prev'              => 1, # #891301
                 'schema.dct'        => 1, # #736992
+                'search'            => 1, # #891301
             );
             return if ($allowed{$relcontent});
             if ($relcontent eq 'alternate') {
diff --git a/debian/changelog b/debian/changelog
index b0c476f..1df4688 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,10 @@ lintian (2.5.77) UNRELEASED; urgency=medium
       with invalid or missing Built-Using headers.  (Closes: #891072)
     + [CL] Apply patch from Michael Stapelberg to warn when packages do not
       specify a XS-Go-Import-Path.  (Closes: #891184)
+  * checks/rules.pm:
+    + [CL] Allow rel="generator" and others; they do not cause internet
+      access by default.  Thanks to Raphaël Hertzog for the report.
+      (Closes: #891301)
   * checks/version-substvars.pm:
     + [CL] Fix a bug in version-substvar-for-external-package parsing to
       prevent false-positives when the LHS of the binary relation contains
diff --git a/t/tests/files-privacybreach/debian/src/privacy-breach-generic/link-generator.xml b/t/tests/files-privacybreach/debian/src/privacy-breach-generic/link-generator.xml
new file mode 100644
index 0000000..fcefd53
--- /dev/null
+++ b/t/tests/files-privacybreach/debian/src/privacy-breach-generic/link-generator.xml
@@ -0,0 +1,2 @@
+<!-- This is a false-positive -->
+<link rel="generator" href="http://example.com";>

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: