[lintian] 02/02: Allow rel="canonical" in <link/> HTML tags; they are used by search engines (etc.) and do not cause internet access. (Closes: #762753)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 2b4ca9b4daf2bb886ef8094108a63e0f8a414a22
Author: Chris Lamb <lamby@debian.org>
Date: Tue Feb 13 14:37:25 2018 +0000
Allow rel="canonical" in <link/> HTML tags; they are used by search engines (etc.) and do not cause internet access. (Closes: #762753)
---
checks/files.pm | 1 +
debian/changelog | 3 +++
.../debian/src/privacy-breach-generic/link-canonical.xml | 2 ++
t/tests/files-privacybreach/tags | 2 --
4 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/checks/files.pm b/checks/files.pm
index e4480c1..8f2ee62 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -2053,6 +2053,7 @@ sub _check_tag_url_privacy_breach {
if (defined($relcontent)) {
my %allowed = (
'bookmark' => 1, # #746656
+ 'canonical' => 1, # #762753
'generator-home' => 1, # texinfo
'schema.dct' => 1, # #736992
);
diff --git a/debian/changelog b/debian/changelog
index 711b25f..1c499f8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,9 @@ lintian (2.5.75) UNRELEASED; urgency=medium
* checks/files.pm:
+ [CL] Tidy logic for detecting allowed rel="" values in <link/>
HTML tags.
+ + [CL] Allow rel="canonical" in <link/> HTML tags; they are used by
+ search engines (etc.) and do not cause internet access.
+ (Closes: #762753)
* checks/init.desc:
+ [CL] Improve various parts of the long description for
init.d-script-should-always-start-service.
diff --git a/t/tests/files-privacybreach/debian/src/privacy-breach-generic/link-canonical.xml b/t/tests/files-privacybreach/debian/src/privacy-breach-generic/link-canonical.xml
new file mode 100644
index 0000000..620ebc3
--- /dev/null
+++ b/t/tests/files-privacybreach/debian/src/privacy-breach-generic/link-canonical.xml
@@ -0,0 +1,2 @@
+<!-- This is a false-positive -->
+<link rel="canonical" href="http://example.com";>
diff --git a/t/tests/files-privacybreach/tags b/t/tests/files-privacybreach/tags
index cfcf319..eaedc9e 100644
--- a/t/tests/files-privacybreach/tags
+++ b/t/tests/files-privacybreach/tags
@@ -77,5 +77,3 @@ W: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/pr
W: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/typekit.html [<script type="text/javascript" src="//use.typekit.net/uniquecodehere.js">] (//use.typekit.net/uniquecodehere.js)
W: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/video.html [<video width="320" height="240" src="ftp://1984.os/tuxistrackingme.ogg"; />] (ftp://1984.os/tuxistrackingme.ogg)
W: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/videoposter.html [<video width="320" height="240" src="tux.ogg" poster="ftp://1984.os/tuxistrackingme.ogg"; />] (ftp://1984.os/tuxistrackingme.ogg)
-W: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-google-plus/asyncload.html [<link rel="canonical" href="http://www.example.com"; />] (http://www.example.com)
-W: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-google-plus/explicitload.html [<link rel="canonical" href="http://www.example.com"; />] (http://www.example.com)
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: