Bug#858588: lintian: Classification tag for missing systemd units

[Lucas Nussbaum <lucas@debian.org>]

On 03/02/18 at 04:00 +0530, Chris Lamb wrote:
> tags 858588 + moreinfo
> thanks
> 
> Hi Lucas,
> 
> > It would be great to add a classification tag in the case where
> > no service file is provided for an init script, even if the maintainer
> > did not make any other effort to make the package work with systemd.
>   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> I can't quite get/parse this bit. :)  As you quote, the code is:

Yeah, it was hard to parse it again for me too :-)

>     tag 'systemd-no-service-for-init-script', $basename
>       if (%{$services} and not $services->{$servicename});
> 
> .. but surely this captures the idea of /etc/init.d/foo exists yet
> there is no foo.service?  ie. the systemd unit is missing.
> 
> (It might helpful in a concrete sense to give an example of a package
> that is not being triggered by the above but would be triggered by
> your proposed tag?)

This tag:
https://lintian.debian.org/tags/systemd-no-service-for-init-script.html
is only emitted if:
   there's an init script without a corresponding service file
 AND
   there are other init scripts in the package with a corresponding
   service file

My point is that it would be useful to have a tag emitted when a package
ships an init script without a corresponding service file, regardless of
whether there are other init scripts with a corresponding service file
in the package.

I could even argue that the above tag is misnamed, and should be e.g.
 systemd-no-service-file-for-init-script-but-other-init-scripts-have-service-file

An example is dictd. It should raise 
   systemd-no-service-file-for-init-script
But not
   systemd-no-service-file-for-init-script-but-other-init-scripts-have-service-file

Lucas