[lintian] 03/03: Make a large number of changes suggested by Mattia Rizzolo to the override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES tag, renaming it to reference DEB_BUILD_OPTIONS throughout, add Debian Policy 4.9.1 to the tag's Ref, lower "Certanty" to "wild-guess" and mark the tag as experimental, updating the tests to match. (Closes: #889746)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit db665d698523b6e207596820c5eff4d88ad1394e
Author: Chris Lamb <lamby@debian.org>
Date: Tue Feb 6 18:34:46 2018 +0000
Make a large number of changes suggested by Mattia Rizzolo to the override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES tag, renaming it to reference DEB_BUILD_OPTIONS throughout, add Debian Policy 4.9.1 to the tag's Ref, lower "Certanty" to "wild-guess" and mark the tag as experimental, updating the tests to match. (Closes: #889746)
---
checks/rules.desc | 9 +++++----
checks/rules.pm | 2 +-
debian/changelog | 6 ++++++
.../desc | 2 +-
.../desc | 2 +-
.../desc | 2 +-
.../desc | 2 +-
.../desc | 2 +-
.../desc | 2 +-
t/tests/rules-dh-auto-test-does-not-check-deb-build-options/desc | 2 +-
t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags | 2 +-
11 files changed, 20 insertions(+), 13 deletions(-)
diff --git a/checks/rules.desc b/checks/rules.desc
index 581d4a0..a2fff9a 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -347,12 +347,13 @@ Info: The debian/rules file appears to be an unmodified or insufficiently
.
Please double-check the rules file.
-Tag: override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
+Tag: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
Severity: wishlist
-Certainty: possible
+Certainty: wild-guess
+Experimental: yes
Info: The <tt>debian/rules</tt> file for this package has an
<tt>override_dh_auto_test</tt> target that does not appear to
- check <tt>DEB_BUILD_PROFILES</tt> against <tt>nocheck</tt>.
+ check <tt>DEB_BUILD_OPTIONS</tt> against <tt>nocheck</tt>.
.
As this check is not automatically performed by debhelper(1), the
specified testsuite is run regardless of using the <tt>nocheck</tt>
@@ -370,4 +371,4 @@ Info: The <tt>debian/rules</tt> file for this package has an
# Disabled
: Disabled
echo "Disbled"
-Ref: https://wiki.debian.org/BuildProfileSpec#Registered_profile_names
+Ref: policy 4.9.1, https://wiki.debian.org/BuildProfileSpec#Registered_profile_names
diff --git a/checks/rules.pm b/checks/rules.pm
index 219b677..035bfb5 100644
--- a/checks/rules.pm
+++ b/checks/rules.pm
@@ -445,7 +445,7 @@ sub run {
if (my $line = $overridden{'dh_auto_test'}) {
my @lines = grep { $_ !~ m/^\t\s*-?(?::|dh_auto_test|echo)\s+/ }
@{$rules_per_target{'override_dh_auto_test'}};
- tag 'override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES',
+ tag 'override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS',
"(line $line)"
if @lines
and none { m/(DEB_BUILD_OPTIONS|nocheck)/ } @conditionals;
diff --git a/debian/changelog b/debian/changelog
index 764ea94..615eb93 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -29,6 +29,12 @@ lintian (2.5.74) UNRELEASED; urgency=medium
+ [CL] Fix a number of false-positives when checking the
"override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES" tag
(Closes: #889592)
+ + [CL] Make a large number of changes suggested by Mattia Rizzolo to
+ the override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES tag,
+ renaming it to reference DEB_BUILD_OPTIONS throughout, add Debian
+ Policy 4.9.1 to the tag's Ref, lower "Certanty" to "wild-guess" and
+ mark the tag as experimental, updating the tests to match.
+ (Closes: #889746)
+ [CL] Check for debian/rules files that are dh_make templates.
(Closes: #679124)
* checks/scripts.desc:
diff --git a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-a/desc b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-a/desc
index b333c85..7d2982f 100644
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-a/desc
+++ b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-a/desc
@@ -2,4 +2,4 @@ Testname: rules-dh-auto-test-does-not-check-deb-build-options-unrel-a
Version: 1.0
Description: Test for missing checks for DEB_BUILD_PROFILES (false-positive)
Test-Against:
- override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
+ override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
diff --git a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-b/desc b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-b/desc
index acf5ced..90fc048 100644
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-b/desc
+++ b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-b/desc
@@ -2,4 +2,4 @@ Testname: rules-dh-auto-test-does-not-check-deb-build-options-unrel-b
Version: 1.0
Description: Test for missing checks for DEB_BUILD_PROFILES (false-positive)
Test-Against:
- override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
+ override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
diff --git a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-c/desc b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-c/desc
index 31dc897..fb5a94e 100644
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-c/desc
+++ b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-c/desc
@@ -2,4 +2,4 @@ Testname: rules-dh-auto-test-does-not-check-deb-build-options-unrel-c
Version: 1.0
Description: Test for missing checks for DEB_BUILD_PROFILES (false-positive)
Test-Against:
- override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
+ override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
diff --git a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-d/desc b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-d/desc
index 1f1b873..21d18ba 100644
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-d/desc
+++ b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-d/desc
@@ -2,4 +2,4 @@ Testname: rules-dh-auto-test-does-not-check-deb-build-options-unrel-d
Version: 1.0
Description: Test for missing checks for DEB_BUILD_PROFILES (false-positive)
Test-Against:
- override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
+ override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
diff --git a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-e/desc b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-e/desc
index 6363be9..f6d976d 100644
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-e/desc
+++ b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-e/desc
@@ -2,4 +2,4 @@ Testname: rules-dh-auto-test-does-not-check-deb-build-options-unrel-e
Version: 1.0
Description: Test for missing checks for DEB_BUILD_PROFILES (false-positive)
Test-Against:
- override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
+ override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
diff --git a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-f/desc b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-f/desc
index a906b09..449a475 100644
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-f/desc
+++ b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel-f/desc
@@ -2,4 +2,4 @@ Testname: rules-dh-auto-test-does-not-check-deb-build-options-unrel-f
Version: 1.0
Description: Test for missing checks for DEB_BUILD_PROFILES (false-positive)
Test-Against:
- override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
+ override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
diff --git a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/desc b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/desc
index 814ee32..cc9607d 100644
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/desc
+++ b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/desc
@@ -2,4 +2,4 @@ Testname: rules-dh-auto-test-does-not-check-deb-build-options
Version: 1.0
Description: Test for missing checks for DEB_BUILD_PROFILES
Test-For:
- override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
+ override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
diff --git a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags
index a94f974..0b862e0 100644
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags
+++ b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags
@@ -1 +1 @@
-I: rules-dh-auto-test-does-not-check-deb-build-options source: override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES (line 6)
+X: rules-dh-auto-test-does-not-check-deb-build-options source: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS (line 6)
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: