[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#889592: lintian: false positive for override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES



Package: lintian
Version: 2.5.73

On Sun, Feb 04, 2018 at 03:36:45PM +0530, Chris Lamb wrote:
> Some results coming in:
> 
>   https://lintian.debian.org/tags/override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES.html
> 
> Thoughts?

Randomly checked few packages and they were mostly all fpos:

https://tracker.debian.org/media/packages/a/aff4/rules-0.24.post1-3
    Ok, this is crazy, he deserves what he got for being too clever with
    make :D

https://tracker.debian.org/media/packages/a/autoconf-dickey/rules-2.52%2B20170501-2
https://tracker.debian.org/media/packages/a/avro-c/rules-1.8.2-1
    Not sure why this is matched, I thought it wouldn't have been:
    |override_dh_auto_test:
    |	dh_auto_test --no-parallel

https://tracker.debian.org/media/packages/libx/libxcb/rules-1.12-1
    Similar to the previous:
    |override_dh_auto_test:
    |	dh_auto_test -- VERBOSE=1

https://tracker.debian.org/media/packages/o/osm2pgsql/rules-0.94.0%2Bds-1
    Also similar:
    |override_dh_auto_test:
    |	dh_auto_test || echo "Ignoring test failures"

https://tracker.debian.org/media/packages/a/akonadi-calendar-tools/rules-417.08.3-2
https://tracker.debian.org/media/packages/b/biosig4c%2B%2B/rules-1.4.1-1.1
    This seems to be a recurring pattern:
    |override_dh_auto_test:
    |	# Disable dh_auto_test at build time
    |	:

https://tracker.debian.org/media/packages/b/bibletime/rules-2.11.1-1
    I believe this is going the be another recurring pattern:
    |override_dh_auto_test:
    |	echo "Skip dh_auto_test because the tests rely on a display which is not there"


Whilst true that the last two technically should deal with
DEB_BUILD_OPTIONS=nocheck, I believe running a single `:` or a single
`echo` should be considered fine.


In my random pick, I saw this real positive:
https://tracker.debian.org/media/packages/l/lua-lgi/rules-0.9.2-1
|override_dh_auto_test:
|	make -C tests all
|	GI_TYPELIB_PATH=tests LD_LIBRARY_PATH=tests xvfb-run dh_auto_test
I recommend to add a similar thing to the testsuite, as this one is
*also* calling dh_auto_test, but it should still handle
DEB_BUILD_OPTIONS=nocheck by hand.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: