[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 02/02: Avoid false positives when checking binary packages depending on toolchain packages by ignoring packages starting with "dh-". Thanks to Josh Triplett for the report. (Closes: #889486)



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit f8d52f6db1309feb076c938923518e7e323e46d8
Author: Chris Lamb <lamby@debian.org>
Date:   Sun Feb 4 08:57:50 2018 +0000

    Avoid false positives when checking binary packages depending on toolchain packages by ignoring packages starting with "dh-". Thanks to Josh Triplett for the report. (Closes: #889486)
---
 checks/fields.pm                                        |  1 +
 debian/changelog                                        |  4 ++++
 t/tests/fields-depends-general/debian/debian/control.in | 12 ++++++++++++
 3 files changed, 17 insertions(+)

diff --git a/checks/fields.pm b/checks/fields.pm
index d04acab..2ced6ff 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -906,6 +906,7 @@ sub run {
                     tag 'binary-package-depends-on-toolchain-package',
                       "$field: $part_d_orig"
                       if $KNOWN_TOOLCHAIN->known($d_pkg)
+                      and not $pkg =~ m/^dh-/
                       and not $DH_ADDONS_VALUES{$pkg};
 
                     # default-jdk-doc must depend on openjdk-X-doc (or
diff --git a/debian/changelog b/debian/changelog
index 232872a..432d8a5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,10 @@ lintian (2.5.74) UNRELEASED; urgency=medium
 
   * checks/cruft.desc:
     + [BR] Check for wasm files.  (Closes: #889102)
+  * checks/fields.pm:
+    + [CL] Avoid false positives when checking binary packages depending on
+      toolchain packages by ignoring packages starting with "dh-". Thanks to
+      Josh Triplett for the report.  (Closes: #889486)
 
  -- Chris Lamb <lamby@debian.org>  Sat, 03 Feb 2018 10:51:52 +0000
 
diff --git a/t/tests/fields-depends-general/debian/debian/control.in b/t/tests/fields-depends-general/debian/debian/control.in
index 2844548..5b610cc 100644
--- a/t/tests/fields-depends-general/debian/debian/control.in
+++ b/t/tests/fields-depends-general/debian/debian/control.in
@@ -55,3 +55,15 @@ Description: {$description} - Fake Doc package
  be an empty package.
  .
  The fake doc package.
+
+Package: dh-{$source}
+Architecture: {$architecture}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, debhelper
+Description: {$description} - Fake Debhelper package
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.
+ .
+ The fake Debhelper package to test false-positives in
+ binary-package-depends-on-toolchain-package.

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: