[lintian] 02/02: Add pedantic warning for packages using source.lintian-overrides instead of debian/source/lintian-overrides.
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 22d4ce0e2ac59b9db339328ff091606fea60647f
Author: Chris Lamb <lamby@debian.org>
Date: Sat Feb 3 09:53:50 2018 +0000
Add pedantic warning for packages using source.lintian-overrides instead of debian/source/lintian-overrides.
---
checks/cruft.desc | 11 +++++++++++
checks/cruft.pm | 3 +++
debian/changelog | 3 +++
t/tests/lintian-output-colons/tags | 1 +
t/tests/lintian-output-letter/tags | 1 +
t/tests/lintian-output-xml/tags | 1 +
6 files changed, 20 insertions(+)
diff --git a/checks/cruft.desc b/checks/cruft.desc
index 40c6cae..d3cfeef 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -934,3 +934,14 @@ Info: The original source tarball contains the specified examples
Please use <tt>dh_installexamples</tt> to install these to the most
relevant package.
Ref: dh_installexamples(1)
+
+Tag: package-uses-deprecated-source-override-location
+Severity: pedantic
+Certainty: certain
+Info: This Debian package ships Lintian source-level overrides in the
+ <tt>debian/source.lintian-overrides</tt> file.
+ .
+ Please use <tt>debian/source/lintian-overrides</tt> instead; the
+ <tt>debian/source</tt> directory is preferred to hold "source"-specific
+ files.
+Ref: lintian 2.4
diff --git a/checks/cruft.pm b/checks/cruft.pm
index 7eb7116..7ebf4bf 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -344,6 +344,9 @@ sub run {
tag 'debian-files-list-in-source';
}
+ tag 'package-uses-deprecated-source-override-location'
+ if $info->index_resolved_path('debian/source.lintian-overrides');
+
# This doesn't really belong here, but there isn't a better place at the
# moment to put this check.
my $version = $info->field('version', '0-1');
diff --git a/debian/changelog b/debian/changelog
index 8b461aa..42068c2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -23,6 +23,9 @@ lintian (2.5.73) UNRELEASED; urgency=medium
package contained an upstream signature.
+ [CL] Check for inconsistencies between "Files" and Checksums-*
sections in .changes files. (Closes: #658542)
+ * checks/cruft.{desc.pm}:
+ + [CL] Add pedantic warning for packages using source.lintian-overrides
+ instead of debian/source/lintian-overrides.
* checks/fields.{desc,pm}:
+ [CL] Add a pedantic warning for co-maintained packages that are not
managed in a revision control system. (Closes: #884497)
diff --git a/t/tests/lintian-output-colons/tags b/t/tests/lintian-output-colons/tags
index 20987cc..4957553 100644
--- a/t/tests/lintian-output-colons/tags
+++ b/t/tests/lintian-output-colons/tags
@@ -11,6 +11,7 @@ tag:I:wishlist:wild-guess::lintian-output-colons:1.0+dsfg-1.1:all:binary:descrip
tag:P:pedantic:certain::lintian-output-colons:1.0+dsfg-1.1:source:source:debian-control-has-unusual-field-spacing:line 12:
tag:P:pedantic:certain::lintian-output-colons:1.0+dsfg-1.1:source:source:debian-watch-does-not-check-gpg-signature::
tag:P:pedantic:certain::lintian-output-colons:1.0+dsfg-1.1:source:source:direct-changes-in-diff-but-no-patch-system:Changes:
+tag:P:pedantic:certain::lintian-output-colons:1.0+dsfg-1.1:source:source:package-uses-deprecated-source-override-location::
tag:P:pedantic:possible::lintian-output-colons:1.0+dsfg-1.1:all:binary:example-unusual-interpreter:usr/share/doc/lintian-output-colons/examples/example #!/usr/bin/foo:
tag:P:pedantic:possible::lintian-output-colons:1.0+dsfg-1.1:source:source:no-homepage-field::
tag:P:pedantic:wild-guess:O:lintian-output-colons:1.0+dsfg-1.1:all:binary:no-upstream-changelog::no-upstream-changelog
diff --git a/t/tests/lintian-output-letter/tags b/t/tests/lintian-output-letter/tags
index 006e164..9c99b2b 100644
--- a/t/tests/lintian-output-letter/tags
+++ b/t/tests/lintian-output-letter/tags
@@ -15,5 +15,6 @@ P[P ]: lintian-output-letter: example-unusual-interpreter usr/share/doc/lintian-
P[P!]: lintian-output-letter source: debian-control-has-unusual-field-spacing line 12
P[P!]: lintian-output-letter source: debian-watch-does-not-check-gpg-signature
P[P!]: lintian-output-letter source: direct-changes-in-diff-but-no-patch-system Changes
+P[P!]: lintian-output-letter source: package-uses-deprecated-source-override-location
W[N ]: lintian-output-letter: binary-without-manpage usr/bin/script
W[N!]: lintian-output-letter source: maintainer-upload-has-incorrect-version-number 1.0+dsfg-1.1
diff --git a/t/tests/lintian-output-xml/tags b/t/tests/lintian-output-xml/tags
index 3af815d..ecf0ee2 100644
--- a/t/tests/lintian-output-xml/tags
+++ b/t/tests/lintian-output-xml/tags
@@ -13,6 +13,7 @@
<tag severity="pedantic" certainty="certain" name="debian-control-has-unusual-field-spacing">line 12</tag>
<tag severity="pedantic" certainty="certain" name="debian-watch-does-not-check-gpg-signature" />
<tag severity="pedantic" certainty="certain" name="direct-changes-in-diff-but-no-patch-system">Changes</tag>
+<tag severity="pedantic" certainty="certain" name="package-uses-deprecated-source-override-location" />
<tag severity="pedantic" certainty="possible" name="example-unusual-interpreter">usr/share/doc/lintian-output-xml/examples/example #!/usr/bin/foo</tag>
<tag severity="pedantic" certainty="possible" name="no-homepage-field" />
<tag severity="pedantic" certainty="wild-guess" flags="overridden" name="no-upstream-changelog" />
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: