[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [lintian] 04/07: Check for packages that specify binary dependencies on toolchain packages such as cdbs or debhelper. (Closes: #700953)



Chris Lamb:
> This is an automated email from the git hooks/post-receive script.
> 
> lamby pushed a commit to branch master
> in repository lintian.
> 
> commit d177589edbef64aa837ff3984f9fa387ec3d819c
> Author: Chris Lamb <lamby@debian.org>
> Date:   Mon Jan 29 05:28:31 2018 +0000
> 
>     Check for packages that specify binary dependencies on toolchain packages such as cdbs or debhelper. (Closes: #700953)
> ---
>  [...]
> diff --git a/checks/fields.desc b/checks/fields.desc
> index fe4dbbe..24f0f58 100644
> --- a/checks/fields.desc
> +++ b/checks/fields.desc
> [...]
> +
> +Tag: binary-package-depends-on-toolchain-package
> +Severity: normal
> +Certainty: possible
> +Info: The package specifies a binary dependecy on a "toolchain" package
> + such as debhelper or cdbs. This is likely to a mistake as these packages
> + are typically specified as build-dependencis.
> + .
> + If the package intentionally requires such a dependency, please add a
> + Lintian override.
> diff --git a/checks/fields.pm b/checks/fields.pm
> index c0a3509..872a6ec 100644
> --- a/checks/fields.pm
> +++ b/checks/fields.pm
> @@ -43,6 +43,7 @@ use constant {
>  };
>  
>  our $KNOWN_ESSENTIAL = Lintian::Data->new('fields/essential');
> +our $KNOWN_TOOLCHAIN = Lintian::Data->new('fields/toolchain');
>  our $KNOWN_METAPACKAGES = Lintian::Data->new('fields/metapackages');
>  our $NO_BUILD_DEPENDS = Lintian::Data->new('fields/no-build-depends');
>  our $KNOWN_SECTIONS = Lintian::Data->new('fields/archive-sections');
> @@ -893,6 +894,10 @@ sub run {
>                          && $pkg !~ m/-(?:dev|docs?|tools|bin)$/
>                          && $part_d_orig =~ m/-docs?$/);
>  
> +                    tag 'binary-package-depends-on-toolchain-package',
> +                      "$field: $part_d_orig"
> +                      if $KNOWN_TOOLCHAIN->known($d_pkg);
> +
>                      # default-jdk-doc must depend on openjdk-X-doc (or
>                      # classpath-doc) to be useful; other packages
>                      # should depend on default-jdk-doc if they want
> [...]
> 

Hi,

I think this check is too simple;  there are plenty of packages with a
legitimate dependency on debhelper, such as all of packages providing a
dh_* tool.

Thanks,
~Niels


Reply to: