[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 02/07: checs/java.pm: Use dirname(...) over regular expressions.



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit ff645070dafaa2f5e4d2d0ff30d875610987f432
Author: Chris Lamb <lamby@debian.org>
Date:   Mon Jan 29 01:44:17 2018 +0000

    checs/java.pm: Use dirname(...) over regular expressions.
---
 checks/java.pm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/checks/java.pm b/checks/java.pm
index 98a0a6b..16b2fd6 100644
--- a/checks/java.pm
+++ b/checks/java.pm
@@ -53,7 +53,7 @@ sub run {
         my $files = $java_info->{$jar_file}{files};
         my $manifest = $java_info->{$jar_file}{manifest};
         my $operm = $info->index($jar_file)->operm;
-        my $jar_dir;
+        my $jar_dir = dirname($jar_file);
         my $classes = 0;
         my $datafiles = 1;
         my $cp = '';
@@ -69,10 +69,7 @@ sub run {
         # Ignore Mozilla's jar files, see #635495
         next if $jar_file =~ m#usr/lib/xul(?:-ext|runner[^/]*+)/#o;
 
-        $jar_dir = $jar_file;
-        $jar_dir =~ s,[^/]+$,,o;
         $has_jars = 1;
-
         if($jar_file =~ m#^usr/share/java/[^/]+\.jar$#o) {
             $has_public_jars = 1;
         }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: