[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 03/04: Include the offending package name when warning about new-package-should-not-package-python2-module.



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 9df68738cf190b0939245b38b6aeb2390a70b651
Author: Chris Lamb <lamby@debian.org>
Date:   Tue Jan 9 22:29:39 2018 +0530

    Include the offending package name when warning about new-package-should-not-package-python2-module.
---
 checks/python.desc                      | 4 ++--
 checks/python.pm                        | 2 +-
 debian/changelog                        | 2 ++
 t/tests/python-new-python2-package/tags | 2 +-
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/checks/python.desc b/checks/python.desc
index c5cc9a6..0f15677 100644
--- a/checks/python.desc
+++ b/checks/python.desc
@@ -9,7 +9,7 @@ Severity: normal
 Certainty: certain
 Info: This package appears to be the initial packaging of a new upstream
  software package (ie. it contains a single changelog entry). However, it
- ships a module for Python 2.
+ ships the specified module for Python 2.
  .
  Python 2.x modules should not be packaged unless strictly necessary (such
  as being explicitly requested by an end-user or required as part of a
@@ -25,7 +25,7 @@ Info: This package appears to be the initial packaging of a new upstream
  if it is a split of an existing Debian package.
  .
  Please add a justification to your changelog entry; Lintian looks in this
- version's changelog entry for the relevant package name or the phrase
+ version's changelog entry for the specified package name or the phrase
  "Python 2 version" or similar.
 
 Tag: python-foo-but-no-python3-foo
diff --git a/checks/python.pm b/checks/python.pm
index bb44163..d77863b 100644
--- a/checks/python.pm
+++ b/checks/python.pm
@@ -107,7 +107,7 @@ sub _run_binary {
         and @entries == 1
         and $entries[0]->Changes !~ /\bpython 2(\.x)? (variant|version)\b/im
         and index($entries[0]->Changes, $pkg) == -1) {
-        tag 'new-package-should-not-package-python2-module';
+        tag 'new-package-should-not-package-python2-module', $pkg;
     }
 
     # Python applications
diff --git a/debian/changelog b/debian/changelog
index 4a8a449..b21e81a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,8 @@ lintian (2.5.69) UNRELEASED; urgency=medium
       the maintainer justifies its inclusion in the changelog entry.
     + [CL] Improve the description and reasoning for the
       new-package-should-not-package-python2-module tag.
+    + [CL] Include the offending package name when warning about
+      new-package-should-not-package-python2-module.
 
  -- Chris Lamb <lamby@debian.org>  Tue, 09 Jan 2018 20:55:21 +0530
 
diff --git a/t/tests/python-new-python2-package/tags b/t/tests/python-new-python2-package/tags
index d38b77b..d523986 100644
--- a/t/tests/python-new-python2-package/tags
+++ b/t/tests/python-new-python2-package/tags
@@ -1 +1 @@
-W: python-python-new-python2-package: new-package-should-not-package-python2-module
+W: python-python-new-python2-package: new-package-should-not-package-python2-module python-python-new-python2-package

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: