[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#886566: lintian: please detect useless usage of the quilt dh addon



Package: lintian
Severity: wishlist

I'm looking at a very simple package, src:stepic at version 0.3-6.

head of d/control:
|Source: stepic
|Section: graphics
|Priority: optional
|Maintainer: Scott Kitterman <scott@kitterman.com>
|Build-Depends: debhelper (>= 9~), python3-all, dh-python, quilt
|Standards-Version: 4.1.3

full d/rules:
|#!/usr/bin/make -f
|
|%:
|	dh $@ --with python3,quilt --buildsystem=pybuild
|
|override_dh_python3:
|	dh_python3 -p stepic
|
|override_dh_installchangelogs:
|	rm -rf $(CURDIR)/debian/stepic/usr/share/doc/stepic/COPYING
|	dh_installchangelogs
|
|override_dh_clean:
|	rm -rf $(CURDIR)/build
|	dh_clean

Here that `--with quilt` (and related quilt build dep) is totally
useless (actually, its behaviour may be confusing to some).
This is of course a '3.0 (quilt)' source package (and this proposed
check should be limited to those kind of sources).

Please emit a severity:wishlist tag about that useless dh-addon (ISTR
(but should be confirmed) that once the `--with quilt` is removed there
is already a tag warning about the usekess build-dep).

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: