[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [lintian] 01/01: Ensure that bugs-field-does-not-refer-to-debian-infrastructure can be overridden by not emitting them for -dbgsym packages. Thanks to Thorsten Glaser for the report. (Closes: #886426)



Chris Lamb:
> This is an automated email from the git hooks/post-receive script.
> 
> lamby pushed a commit to branch master
> in repository lintian.
> 
> commit 5f25c74cbebfa429837e6078278fab9f95ac73d6
> Author: Chris Lamb <lamby@debian.org>
> Date:   Sat Jan 6 10:30:49 2018 +0000
> 
>     Ensure that bugs-field-does-not-refer-to-debian-infrastructure can be overridden by not emitting them for -dbgsym packages. Thanks to Thorsten Glaser for the report. (Closes: #886426)
> ---
>  checks/fields.pm                                             |  2 +-
>  debian/changelog                                             |  3 +++
>  .../debian/debian/control.in                                 | 12 ++++++++++++
>  .../tags                                                     |  1 +
>  4 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/checks/fields.pm b/checks/fields.pm
> index 01d120c..fa0d697 100644
> --- a/checks/fields.pm
> +++ b/checks/fields.pm
> @@ -1238,7 +1238,7 @@ sub run {
>  
>          tag 'bugs-field-does-not-refer-to-debian-infrastructure', $bugs,
>            "(line $.)"
> -          unless $bugs =~ m,\.debian\.org,;
> +          unless $bugs =~ m,\.debian\.org, or $pkg =~ /[-]dbgsym$/;
>      }
>  
> [...]

Hi,

I think it would make more sense to exclude any "auto-generated" binary
packages rather than just packages named "-dbgsym".  This can be done by
using:

  $info->is_pkg_class('auto-generated')
  (Only applicable if $info is an instance of L::Collect::Binary)

Alternatively, perhaps we should only check this for source packages?

Thanks,
~Niels




Reply to: