[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: [CL] Warn about orphaned packages that are not maintained in the Debian infrastucture. (Closes: #886057)



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch 886057-lintian-warn-about-orphaned-package-not-maintained-in-debianorg-infrastracture
in repository lintian.

commit 29848bbe3a870a17d88f1633f586df4151b8ad23
Author: Chris Lamb <lamby@debian.org>
Date:   Tue Jan 2 20:29:03 2018 +0000

    [CL] Warn about orphaned packages that are not maintained in the Debian infrastucture. (Closes: #886057)
---
 checks/fields.desc                                      | 14 ++++++++++++++
 checks/fields.pm                                        |  5 +++++
 debian/changelog                                        |  3 +++
 .../debian/debian/changelog.in                          |  7 +++++++
 .../debian/debian/control.in                            | 17 +++++++++++++++++
 .../desc                                                |  7 +++++++
 .../tags                                                |  1 +
 t/tests/nmu-qa-upload/desc                              |  2 ++
 8 files changed, 56 insertions(+)

diff --git a/checks/fields.desc b/checks/fields.desc
index 08f1d55..114ef9a 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1371,3 +1371,17 @@ Info: The <tt>debian/control</tt> file contains a Bugs field that does
  .
  This is likely to make reportbug(1) unable to report bugs.
 Ref: #740944
+
+Tag: orphaned-package-not-maintained-in-debian-infrastracture
+Severity: normal
+Certainty: certain
+Info:
+ This package is orphaned but the specified VCS field does not point to
+ an area within the *.debian.org infrastructure
+ . 
+ This prevents other developers and external contributors to collaborate
+ on its maintenance.
+ .
+ Please move the packaging to under the *.debian.org umbrella.
+ Alternatively, update the specified VCS field is either stale from
+ before it was orphaned, or is otherwise wrong.
diff --git a/checks/fields.pm b/checks/fields.pm
index 5651b94..95f17c4 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -1336,6 +1336,11 @@ sub run {
             tag 'vcs-browser-links-to-empty-view', $uri
               if $vcs eq 'browser' and $uri =~ m%rev=0&sc=0%;
             $seen_vcs{$vcs}++ if $vcs ne 'browser';
+            if (    $info->field('maintainer', '') =~ /packages\@qa.debian.org/
+                and $uri !~ m/\.debian\.org/) {
+                tag 'orphaned-package-not-maintained-in-debian-infrastracture',
+                  "vcs-$vcs", $uri;
+            }
         }
     }
     tag 'vcs-fields-use-more-than-one-vcs', sort keys %seen_vcs
diff --git a/debian/changelog b/debian/changelog
index 986c929..c7da648 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -11,6 +11,9 @@ lintian (2.5.68) UNRELEASED; urgency=medium
   * checks/debconf.pm:
     + [CL] Don't warn about unknown template type "entropy" when a package
       depends on cdebconf.  (Closes: #677870)
+  * checks/fields.pm:
+    + [CL] Warn about orphaned packages that are not maintained in the
+      Debian infrastucture.  (Closes: #886057)
   * checks/python.pm:
     + [CL] Don't warn about django-package-does-not-depend-on-django for
       -doc packages, etc.
diff --git a/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/debian/debian/changelog.in b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/debian/debian/changelog.in
new file mode 100644
index 0000000..c0857b9
--- /dev/null
+++ b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/debian/debian/changelog.in
@@ -0,0 +1,7 @@
+{$source} ({$version}) unstable; urgency=low
+
+  * QA Upload.
+  * Lintian Test Suite.
+  * Suppress "should close ITP bug" messages.  (Closes: #123456)
+
+ -- {$author}  {$date}
diff --git a/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/debian/debian/control.in b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/debian/debian/control.in
new file mode 100644
index 0000000..6913d15
--- /dev/null
+++ b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/debian/debian/control.in
@@ -0,0 +1,17 @@
+Source: {$source}
+Priority: optional
+Section: {$section}
+Maintainer: Debian QA Group <packages@qa.debian.org>
+Standards-Version: {$standards_version}
+Build-Depends: {$build_depends}
+Rules-Requires-Root: no
+Vcs-Git: https://github.com/user/project
+
+Package: {$source}
+Architecture: {$architecture}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: {$description}
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.
diff --git a/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/desc b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/desc
new file mode 100644
index 0000000..63380b0
--- /dev/null
+++ b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/desc
@@ -0,0 +1,7 @@
+Testname: files-orphaned-package-not-maintained-in-debian-infrastracture
+Description: Test for orphaned package not maintained in Debian infrastucture
+Version: 1.0
+Test-For:
+ orphaned-package-not-maintained-in-debian-infrastracture
+Test-Against:
+ changelog-should-mention-qa
diff --git a/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/tags b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/tags
new file mode 100644
index 0000000..4683946
--- /dev/null
+++ b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/tags
@@ -0,0 +1 @@
+W: files-orphaned-package-not-maintained-in-debian-infrastracture source: orphaned-package-not-maintained-in-debian-infrastracture vcs-git https://github.com/user/project
diff --git a/t/tests/nmu-qa-upload/desc b/t/tests/nmu-qa-upload/desc
index 3dec785..c7ba00a 100644
--- a/t/tests/nmu-qa-upload/desc
+++ b/t/tests/nmu-qa-upload/desc
@@ -6,3 +6,5 @@ Test-For:
  changelog-should-mention-qa
  orphaned-package-should-not-have-uploaders
  qa-upload-has-incorrect-version-number
+Test-Against:
+ orphaned-package-not-maintained-in-debian-infrastracture

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: