Package: lintian Version: 2.5.67 Severity: wishlist Tags: patch Hi, The attached patch set improves the version parsing in changelog. The patches are annotated, but I also copied brief descriptions below. The patches apply to the 2.5.68 master—one after the other, and ordered in likelihood of acceptance. Thank you! Best regards, Felix 0001: c/changelog-file: Fix version parsing for hyphen in upstream version This patch fixes an issue when the upstream version contains a hyphen. While the presence of a hyphen may not be desirable, it is okay according to policy. This patch is superseded by another more elegant patch later in the series. 0002: c/cruft: Fix version parsing for native packages This patch improves version parsing for native packages. It removes an outdated pattern for non-maintainer uploads. The patch is superseded by another patch later in the series. 0003: c/source-changelog: Add version parsing This patch adds version parsing to checks/source-changelog, where it may be more appropriate than in the various places it is presently. The parsing employs a somewhat long but hopefully correct regular expression. 0004: c/cruft: Transfer native and non-native version checking to c/source-changelog This patch transfers two checks for version strings from checks/cruft to checks/source-changelog, where they may a better home. The original author also thought they did not belong in their original place. That deficiency is now cured. 0005: c/source-changelog: Add version info to native and non-native tag output This patch prints the offending version string when the tags 'native-package-with-dash-version' or 'non-native-package-with-native-version' are emitted. Perhaps it helps the user. 0006: c/source-changelog: Add tag for hyphens in upstream versions This patch adds a new tag 'hyphen-in-upstream-version' to warn about the legal but occasionally perilous presence of hyphens in version strings. It was the original motivation behind this patch series. I had accidentally uploaded a package with such a version and tried to work on it with Debian tools for shared libraries (dpkg-gensymbols or its KDE cousin). I would like to see such a warning in the future, if possible. 0007: c/source-changelog: Rename tag 'native-package-with-dash-version' to 'hyphen-in-native-version' This patch renames the tag 'native-package-with-dash-version' to 'hyphen-in-native-version'. The tag is totally related to 'hyphen-in-upstream-version' and deserves a less crufty and perhaps less cryptic name. 0008: c/source-changelog: Rename tag 'non-native-package-with-native-version' to 'debian-changelog-missing-debian-revision' This patch renames the tag 'non-native-package-with-native-version' to 'debian-changelog-missing-debian-revision'. It is an attempt to add clarity and userfriendliness to the name. checks/changelog-file.pm | 8 +++--- checks/cruft.desc | 35 ------------------------ checks/cruft.pm | 14 ---------- checks/source-changelog.desc | 46 ++++++++++++++++++++++++++++++++ checks/source-changelog.pm | 38 ++++++++++++++++++++++++++ t/tests/changelog-file-experimental/tags | 2 +- t/tests/changelog-file-general/desc | 8 +++++- t/tests/changelog-file-general/tags | 1 + t/tests/cruft-native-dash-version/desc | 3 ++- t/tests/cruft-native-dash-version/tags | 2 +- t/tests/cruft-non-native-version/desc | 3 ++- t/tests/cruft-non-native-version/tags | 2 +- t/tests/legacy-binary/desc | 2 +- t/tests/legacy-binary/tags | 2 +- t/tests/legacy-fields/desc | 2 +- t/tests/legacy-fields/tags | 2 +- t/tests/legacy-filenames/tags | 1 + t/tests/legacy-libbaz/desc | 2 +- t/tests/legacy-libbaz/tags | 2 +- t/tests/legacy-maintainer-scripts/tags | 1 + 20 files changed, 111 insertions(+), 65 deletions(-) -- 2.15.1
Attachment:
improve-changelog-version-parsing.tar.xz
Description: application/xz