Bug#884678: lintian: please consider debhelper compat 11 as stable

[Niels Thykier <niels@thykier.net>]

Chris Lamb:
> Hi Mattia,
> 
>> -    $data->{'dh_compat_level'} //= '9';
>> +    $data->{'dh_compat_level'} //= '11';
>>
>> causes a ton of package-needs-versioned-debhelper-build-depends to be
>> emitted…
> 
> I don't understand why this happens. Changing this does certainly change
> the default in tests. For example, here is "changelog-file-symlink"'s 
> debian/control:
> 
>   1 Source: changelog-file-symlink
>   2 Priority: optional
>   3 Section: devel
>   4 Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
>   5 Standards-Version: 4.1.2
>   6 Build-Depends: debhelper (>= 11~)
> 
> .. so I have no idea why this fails the following test in
> checks/debhelper.pm:
> 
>     unless ($bdepends->implies("debhelper (>= ${dh_bd_version}~)")){
> 
> $dh_bd_version is indeed 11 here.
> 
> 
> Regards,
> 

Elementary my dear dr. Watson, the B-D in the .dsc.in.in file of the
test is hard coded!

"""
$ less t/source/changelog-file-symlink/dsc.in.in
Format: 1.0
[...]
Build-Depends: debhelper (>= 9)
[...]
"""

(Note that changelog-file-symlink name is reused between the t/tests and
the t/source suite.   Only the latter fails).

Ideally, we would reduce the level of hard-coding here by ensuring that
the .dsc.in.in uses the substitution variable where possible.  The use
of {$dh_compat_level} and .dsc.in.in are relatively "new inventions" so
many tests are still hard-coded.

Thanks,
~Niels