[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: Correct false positives in the "source-includes-file-in-files-excluded" tag where a Files-Excluded of "lib/*" would be triggered for "foolib/filename".



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 8d58d79e05d4719394db69dc1d8ad98bdb33289d
Author: Chris Lamb <lamby@debian.org>
Date:   Thu Dec 7 09:49:00 2017 +0000

    Correct false positives in the "source-includes-file-in-files-excluded" tag where a Files-Excluded of "lib/*" would be triggered for "foolib/filename".
---
 checks/source-copyright.pm                                            | 2 +-
 debian/changelog                                                      | 4 ++++
 .../source-copyright-source-files-excluded/debian/debian/copyright    | 1 +
 .../debian/foolib/false-positive                                      | 0
 4 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/checks/source-copyright.pm b/checks/source-copyright.pm
index 11ab949..7ee9c8a 100644
--- a/checks/source-copyright.pm
+++ b/checks/source-copyright.pm
@@ -632,7 +632,7 @@ sub check_files_excluded {
             $wc_value = qr/^${wc_value}(?:\/|$)/;
         }
         for my $srcfile (@files) {
-            if ($srcfile =~ $wc_value) {
+            if ($srcfile =~ qr/^$wc_value/) {
                 tag 'source-includes-file-in-files-excluded',$srcfile;
                 last;
             }
diff --git a/debian/changelog b/debian/changelog
index dd4c27e..01b72cc 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -20,6 +20,10 @@ lintian (2.5.62) UNRELEASED; urgency=medium
       indeed bad (#769845 and the mail referred to in there). Rewrite
       recommendations, explain what conditions should be given if someone
       intents to override this tag. (Closes: #807695)
+  * checks/source-copyright.pm:
+    + [CL] Correct false positives in the
+      "source-includes-file-in-files-excluded" tag where a Files-Excluded
+      of "lib/*" would be triggered for "foolib/filename".
 
   * data/spelling/corrections:
     + [AB] Remove "publically". It's a seldom, but valid English word
diff --git a/t/tests/source-copyright-source-files-excluded/debian/debian/copyright b/t/tests/source-copyright-source-files-excluded/debian/debian/copyright
index 291bb45..9864c95 100644
--- a/t/tests/source-copyright-source-files-excluded/debian/debian/copyright
+++ b/t/tests/source-copyright-source-files-excluded/debian/debian/copyright
@@ -5,6 +5,7 @@ Files-Excluded: exclude-this
  exclude-dir-2/*
  .*
  */js/jquery.js
+ lib/*
 
 Files: *
 Copyright: 2011 J. Random Hacker <j.r.hacker@example.com>
diff --git a/t/tests/source-copyright-source-files-excluded/debian/foolib/false-positive b/t/tests/source-copyright-source-files-excluded/debian/foolib/false-positive
new file mode 100644
index 0000000..e69de29

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: