[lintian] 01/01: d…/s…/corrections: Remove seldom, but valid English word "publically"
This is an automated email from the git hooks/post-receive script.
abe pushed a commit to branch master
in repository lintian.
commit 33ca950a3050af4bc99230948d682fb6de292395
Author: Axel Beckert <abe@deuxchevaux.org>
Date: Wed Dec 6 22:13:52 2017 +0100
d…/s…/corrections: Remove seldom, but valid English word "publically"
According to https://en.wiktionary.org/wiki/publically, "publically"
is a "(rare) Alternative spelling of publicly" which is indeed said to
be "generally considered more correct". But that doesn't make
"publically" incorrect.
Additionally "publically" is used in the last paragraph of the OpenSSL
license (c.f. https://spdx.org/licenses/OpenSSL and
https://www.openssl.org/source/license.html) and hence causes quite
some false positives for spelling-error-in-copyright. As of today,
https://lintian.debian.org/tags/spelling-error-in-copyright.html
showed 269 cases of which probably many are due to the OpenSSL
License.
Nevertheless, alone to avoid lintian overrides for hundreds of
packages being licensed under the OpenSSL license, this overzealous
spelling correction needs to be removed.
Additionally, its future re-addition should be avoided, too, for the
same reasons.
---
data/spelling/corrections | 1 -
debian/changelog | 10 ++++++++++
t/scripts/spellintian.t | 15 ++++++++++++++-
3 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/data/spelling/corrections b/data/spelling/corrections
index 8ac4984..9ad4748 100644
--- a/data/spelling/corrections
+++ b/data/spelling/corrections
@@ -3005,7 +3005,6 @@ protoypes||prototypes
psaswd||passwd
psuedo||pseudo
psychadelic||psychedelic
-publically||publicly
publicaly||publicly
pusehd||pushed
pyton||python
diff --git a/debian/changelog b/debian/changelog
index c456552..aca4fdb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -13,6 +13,16 @@ lintian (2.5.62) UNRELEASED; urgency=medium
+ [CL] Detect an invalid debian/po/POTFILES.in instead of bailing out.
(Closes: #883653)
+ * data/spelling/corrections:
+ + [AB] Remove "publically". It's a seldom, but valid English word
+ (c.f. https://en.wiktionary.org/wiki/publically) and causes false
+ positives in the OpenSSL license.
+
+ * t/scripts/spellintian.t:
+ + [AB] Ensure that "publically" is not re-added as spelling correction
+ in the future again to avoid hundreds of false positives in the
+ OpenSSL license.
+
-- Chris Lamb <lamby@debian.org> Tue, 05 Dec 2017 15:27:44 +0000
lintian (2.5.61) unstable; urgency=medium
diff --git a/t/scripts/spellintian.t b/t/scripts/spellintian.t
index 44f33de..8665ad0 100755
--- a/t/scripts/spellintian.t
+++ b/t/scripts/spellintian.t
@@ -22,7 +22,7 @@
use strict;
use warnings;
-use Test::More tests => 6;
+use Test::More tests => 7;
use IPC::Run();
@@ -49,6 +49,7 @@ t($s, "familar -> familiar\nallows to -> allows one to\ngnu -> GNU\n",
'--picky');
my $iff = 0;
+my $publically = 0;
my $case_sen = 0;
open(my $sp_fh, '<', $spelling_data)
@@ -66,6 +67,12 @@ while (my $corr = <$sp_fh>) {
# Check if "iff" has been added as correction. See #865055 why
# this is wrong. Bad example: iff||if
$iff++ if $corr =~ m{ ^ iff \|\| }x;
+
+ # Check if "publically" has been added as correction. It is a
+ # seldom, but valid English word, is used in the OpenSSL license
+ # and hence causes quite some false positives, when being added
+ # (again).
+ $publically++ if $corr =~ m{ ^ publically \|\| }x;
}
close($sp_fh);
@@ -76,6 +83,12 @@ ok(
. $spelling_data
.'. See #865055 why this is wrong.'
);
+ok(
+ $publically == 0,
+ '"publically" is not present in '
+ . $spelling_data
+ .q{. It's a valid English word and used in the OpenSSL license.}
+);
# Local Variables:
# indent-tabs-mode: nil
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: