[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 03/03: Drop tag rules-requires-root-misses-namespace again



This is an automated email from the git hooks/post-receive script.

abe pushed a commit to branch rules-requires-root-classification
in repository lintian.

commit da42a7795d209fb5ebf7d60170199f081bb4a452
Author: Axel Beckert <abe@deuxchevaux.org>
Date:   Thu Nov 9 19:11:00 2017 +0100

    Drop tag rules-requires-root-misses-namespace again
    
    It's unlikely to be ever emitted as dpkg-deb in Buster already catches
    those cases.
---
 checks/control-file.desc                   | 10 ----------
 checks/control-file.pm                     |  2 --
 debian/changelog                           |  4 +---
 t/source/fields-src-bad-version/control.in |  1 -
 t/source/fields-src-bad-version/desc       |  1 -
 t/source/fields-src-bad-version/tags       |  1 -
 6 files changed, 1 insertion(+), 18 deletions(-)

diff --git a/checks/control-file.desc b/checks/control-file.desc
index f0fe0d7..da3198f 100644
--- a/checks/control-file.desc
+++ b/checks/control-file.desc
@@ -331,13 +331,3 @@ Severity: classification
 Certainty: certain
 Info: Package requires fakeroot or similar to build binary targets and explicitly declares it.
 Ref: /usr/share/doc/dpkg-dev/rootless-builds.txt.gz
-
-Tag: rules-requires-root-misses-namespace
-Severity: normal
-Certainty: possible
-Info: The package has a Rules-Requires-Root header, but its value misses a namespace
- The Rules-Requires-Root header may either contain "no",
- "binary-targets" or a value consisting of a namespace and a keyword
- separated by a slash. This package's Rules-Requires-Root header
- matches neither of these options.
-Ref: /usr/share/doc/dpkg-dev/rootless-builds.txt.gz
diff --git a/checks/control-file.pm b/checks/control-file.pm
index 17e8913..0976964 100644
--- a/checks/control-file.pm
+++ b/checks/control-file.pm
@@ -376,8 +376,6 @@ sub run {
             tag 'rules-does-not-require-root';
         } elsif ($r3 eq 'binary-targets') {
             tag 'rules-requires-root-explicitly';
-        } elsif ($r3 !~ m(/)) {
-            tag 'rules-requires-root-misses-namespace', $r3;
         }
     } else {
         tag 'rules-requires-root-implicitly';
diff --git a/debian/changelog b/debian/changelog
index 4988389..8d189db 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,9 +3,7 @@ lintian (2.5.60) UNRELEASED; urgency=medium
   XXX: generate tag summary
 
   * checks/control-file.{desc,pm}:
-    + [AB] Add classification tags for R³ and emit new tag
-      rules-requires-root-misses-namespace if neither a known value is
-      present nor does the value adhere the <namespace>/<keyword> syntax.
+    + [AB] Add classification tags for R³.
 
  -- Chris Lamb <lamby@debian.org>  Thu, 09 Nov 2017 09:09:49 +0000
 
diff --git a/t/source/fields-src-bad-version/control.in b/t/source/fields-src-bad-version/control.in
index f2f6679..a9377c0 100644
--- a/t/source/fields-src-bad-version/control.in
+++ b/t/source/fields-src-bad-version/control.in
@@ -4,7 +4,6 @@ Priority: optional
 Maintainer: {$author}
 Build-Depends: debhelper (>= 7), g++ (>= s4.0)
 Standards-Version: {$standards_version}
-Rules-Requires-Root: keyword-without-namespace
 
 Package: {$source}
 Architecture: all
diff --git a/t/source/fields-src-bad-version/desc b/t/source/fields-src-bad-version/desc
index 764140f..ab84207 100644
--- a/t/source/fields-src-bad-version/desc
+++ b/t/source/fields-src-bad-version/desc
@@ -3,4 +3,3 @@ Version: 1.0
 Description: Test for d/control with syntax errors
 Test-For: bad-relation
  bad-version-in-relation
- rules-requires-root-misses-namespace
diff --git a/t/source/fields-src-bad-version/tags b/t/source/fields-src-bad-version/tags
index 4c4f41f..6c4633a 100644
--- a/t/source/fields-src-bad-version/tags
+++ b/t/source/fields-src-bad-version/tags
@@ -1,3 +1,2 @@
 E: control-file-syntax-error source: bad-relation build-depends: gcc ((>= 4)
 E: control-file-syntax-error source: bad-version-in-relation build-depends: g++ (>= s4.0)
-W: control-file-syntax-error source: rules-requires-root-misses-namespace keyword-without-namespace

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: