Re: [lintian] branch rules-requires-root-classification created (now 0942dcb)

[Axel Beckert <abe@debian.org>]

Hi,

Axel Beckert wrote:
> This is an automated email from the git hooks/post-receive script.
> 
> abe pushed a change to branch rules-requires-root-classification
> in repository lintian.
> 
>         at  0942dcb   checks/control-file.*: Add classification tags for R³

I was curious how many packages are already using R³ and thought, a
lintian classification tag would the perfect way to figure that out.

I've implemented a bunch of according tags and committed them
including tests in a feature branch called
"rules-requires-root-classification" as can be seen at
https://anonscm.debian.org/git/lintian/lintian.git/commit/?h=rules-requires-root-classification

I'd be happy about reviews on that branch. If there are no objections,
please merge that branch into master.

Some comments on this commit:

* rules-requires-root-misses-namespace might not be necessary as
  building package with a broken R³ field already fails with an
  R³-supporting dpkg-dev version.

  Then again, building with an older dpkg-dev version might just cause
  a warning inmidst of the build log and hence easily overseen.

* Building the lintian package with or without the above commit
  currently fails for me as follows:

    tests::rules-including-deprecated-makefiles: install: cannot change ownership of 'debian/rules-including-deprecated-makefiles/usr/share/doc/rules-including-deprecated-makefiles/buildinfo_all.gz': Operation not permitted

  Running only the failing test with "debian/rules runtests
  onlyrun=rules-including-deprecated-makefiles" after the build fails,
  too, with the same error message.

  Interestingly running "fakeroot debian/rules runtests
  onlyrun=rules-including-deprecated-makefiles" fails as well.

  The fix for this seems to be to add the following contents as
  t/tests/rules-including-deprecated-makefiles/debian/debian/control.in:

---8<---
Source: {$source}
Priority: optional
Section: {$section}
Maintainer: {$author}
Standards-Version: {$standards_version}
Build-Depends: {$build_depends}
Rules-Requires-Root: binary-targets
Homepage: https://lintian.debian.org/

Package: {$source}
Architecture: {$architecture}
Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
Description: {$description}
 This is a test package designed to exercise some feature or tag of
 Lintian.  It is part of the Lintian test suite and may do very odd
 things.  It should not be installed like a regular package.  It may
 be an empty package.
--->8---

  So if I add that file, the test passes. Funnily, if remove that file
  again (e.g. with "git stash -u"), the test continues to pass until I
  run "debclean".

  Confusing.

  Please tell me, if I should add an according commit to fix that, too.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE