[lintian] 01/01: Apply patch from Guillem Jover to strongly discourage the use of the getconf(1) interface for LFS support. (Closes: #879935)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit ba9c7fd96801e3c796d0233b4f7432e55dffe057
Author: Guillem Jover <guillem@debian.org>
Date: Fri Oct 27 13:53:36 2017 +0200
Apply patch from Guillem Jover to strongly discourage the use of the getconf(1) interface for LFS support. (Closes: #879935)
> Recommend against using getconf LFS_CFLAGS which is broken on
> cross-builds. Instead recommend the new dpkg-buildflags lfs feature
> from the future feature area. And reorder Ref links in order of
> relevance.
Signed-off-by: Chris Lamb <lamby@debian.org>
---
checks/binaries.desc | 12 +++++++-----
debian/changelog | 2 ++
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/checks/binaries.desc b/checks/binaries.desc
index 708ad26..4e58220 100644
--- a/checks/binaries.desc
+++ b/checks/binaries.desc
@@ -446,9 +446,11 @@ Info: The listed ELF binary appears to be (partially) built without
were the ABI has LFS enabled by default, setting <tt>_FILE_OFFSET_BITS</tt>
to 64 will be a no-op, and as such optional). This can be done by using
the <tt>AC_SYS_LARGEFILE</tt> macro with autoconf which will set any
- macro required to enable LFS when necessary, or by appending the output
- of <tt>getconf LFS_CFLAGS</tt> and <tt>getconf LFS_LDFLAGS</tt> to
- <tt>CFLAGS</tt> and <tt>LDFLAGS</tt> respectively. Using
+ macro required to enable LFS when necessary, or by enabling the
+ <tt>lfs</tt> feature from the <tt>future</tt> dpkg-buildflags feature
+ area which sets the <tt>CPPFLAGS</tt> variable (since dpkg-dev 1.19.0).
+ Note though, that <tt>getconf LFS_CFLAGS</tt> must <b>not</b> be used,
+ as it does not support cross-building. Using
<tt>_FILE_OFFSET_BITS</tt> should require no system function renames (eg.
from open(2) to open64(2)), and if this tag is still emitted, the most
probable cause is because the macro is not seen by the system code being
@@ -464,5 +466,5 @@ Info: The listed ELF binary appears to be (partially) built without
systems with an ABI without LFS, defining <tt>_LARGEFILE64_SOURCE</tt>
and exporting both 32 and 64-bit variants of the interfaces can avoid
the SOVERSION bump, at the cost of more complex maintenance.
-Ref: https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html,
- http://www.unix.org/version2/whatsnew/lfs20mar.html
+Ref: http://www.unix.org/version2/whatsnew/lfs20mar.html,
+ https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html
diff --git a/debian/changelog b/debian/changelog
index d8f445d..9405ce5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -9,6 +9,8 @@ lintian (2.5.56) UNRELEASED; urgency=medium
+ [CL] Apply patch from Adrian Bunk to mention the lack of the "-g"
flag as a common cause for the debug-file-with-no-debug-symbols tag.
(Closes: #878806)
+ + [CL] Apply patch from Guillem Jover to strongly discourage the use
+ of the getconf(1) interface for LFS support. (Closes: #879935)
* checks/changes-file.desc:
+ [CL] Add a note to orig-tarball-missing-upstream-signature regarding
support in pristine-tar and git-buildpackage.
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: