Am 26.10.2017 um 18:08 schrieb Chris Lamb: > tags 879851 + wontfix > thanks > > Hi Markus, > >> Only trigger package-installs-java-bytecode when number of classes >> exceeds 20 > > Whilst I've fixed the other three issues (pending release), I'm really > not convinced by this one. > > Not only would it add some arbitrary magical number which would be > misleading to developers when fixing issues ("hey, they suddenly all > disappeared!"), we should fix the underlying false positives instead > of papering over the issue with things like this. Hi Chris, let me explain the idea behind this change. At the moment the vast majority of packages build those class files from source and install them for educational or testing purposes. There is actually nothing wrong with installing class files. Though the common case is that class files are compressed and shipped within jar files to save disk space. Hence we think that installing a few class files is usually a non-issue and not worth reporting but if the number exceeds this limit it might be an indication that there was some kind of packaging error because those files should be really inside a jar file. I agree this is an arbitrary number but you have to draw the line somewhere. This tag should really not be confused with source-contains-prebuilt-java-object because this one is about a potential DFSG violation shipping binary files without corresponding source. In most cases those files are just convenience copies but we remove them anyway. Detecting class files in addition to jar files inside a source package would be a good idea. In short: source-contains-prebuilt-java-object -> possible DFSG violation package-installs-java-bytecode -> disk space optimization issue or packaging mistake Regards, Markus
Attachment:
signature.asc
Description: OpenPGP digital signature