[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: .



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch lamby/wip/854134
in repository lintian.

commit 49681fd2ecdaab84cf56862a17dd133d41095df9
Author: Chris Lamb <lamby@debian.org>
Date:   Mon Jul 10 16:39:56 2017 +0100

    .
---
 checks/menu-format.pm | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/checks/menu-format.pm b/checks/menu-format.pm
index 3de4490..cae21c6 100644
--- a/checks/menu-format.pm
+++ b/checks/menu-format.pm
@@ -179,6 +179,19 @@ sub run {
         }
     }
 
+    # Find the icon files in the package for verification.
+    my @icons;
+    warn "hi";
+        if (my $dir = $info->index("usr/share/icons/hicolor")) {
+		warn $dir;
+            for my $file ($dir->children) {
+                next unless $file->is_file;
+                next unless $file->basename =~ m/\.png$/;
+		warn "saw icon $file";
+                push(@icons, $file);
+            }
+        }
+
     # Verify all the desktop files.
     for my $desktop_file (@desktop_files) {
         verify_desktop_file($desktop_file, $pkg, $info, \%desktop_cmds);
@@ -638,9 +651,13 @@ sub verify_desktop_file {
 
     # test if missing Keywords (only if NoDisplay is not set)
     if (!defined $vals{NoDisplay}) {
-        if (!defined $vals{Icon}) {
+        if (defined $vals{Icon}) {
+	    #warn "ICON=" . $vals{'Icon'};
+	    #warn "index" . $info->index('//usr');
+            #tag 'desktop-entry-lacks-icon-entry', "fooooooo $file $vals";
+        } else {
             tag 'desktop-entry-lacks-icon-entry', $file;
-        }
+	}
         if (!defined $vals{Keywords}) {
             tag 'desktop-entry-lacks-keywords-entry', $file;
         }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: