[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: Suggest using /usr/share/dpkg/architecture.mk as a solution to debian-rules-sets-dpkg-architecture-variable rather than simply replacing assignments with ?=. Thanks to Helmut Grohne for the suggestion.



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit d202f4a1b997f14f2d3b7446e49398b1700df614
Author: Chris Lamb <lamby@debian.org>
Date:   Fri Dec 29 09:56:15 2017 +0000

    Suggest using /usr/share/dpkg/architecture.mk as a solution to debian-rules-sets-dpkg-architecture-variable rather than simply replacing assignments with ?=. Thanks to Helmut Grohne for the suggestion.
---
 checks/rules.desc | 6 +++++-
 debian/changelog  | 5 +++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/checks/rules.desc b/checks/rules.desc
index 6a1a992..48a5b65 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -271,7 +271,11 @@ Info: The <tt>debian/rules</tt> file sets one or more
  <tt>dpkg-buildpackage</tt> - avoiding these assignments can reduce package
  build time.
  .
- Please replace the assignment operator with <tt>?=</tt>.
+ Please use:
+ .
+   include /usr/share/dpkg/architecture.mk
+ .
+ instead, or replace the assignment operator with <tt>?=</tt>.
 
 Tag: debian-rules-should-not-set-CFLAGS-from-noopt
 Severity: normal
diff --git a/debian/changelog b/debian/changelog
index f820610..fc154bf 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -15,6 +15,11 @@ lintian (2.5.67) UNRELEASED; urgency=medium
       dependencies *from* packages with such names.  (Closes: #885693)
     + [CL] Also ignore -common packages for intra-Python variant dependency
       checking.
+  * checks/rules.desc:
+    + [CL] Suggest using /usr/share/dpkg/architecture.mk as a solution to
+      debian-rules-sets-dpkg-architecture-variable rather than simply
+      replacing assignments with ?=. Thanks to Helmut Grohne for the
+      suggestion.
   * checks/watch-file.{desc,pm}:
     + [CL] Apply patch from Felix Lechner <felix.lechner@lease-up.com> to
       check for packages where an upstream signature exists but is not

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: