[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/02: Factor out definition of depdendency fields.



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit cd2f44217a731f96fa6bca58f8a4892c11a4ae42
Author: Chris Lamb <lamby@debian.org>
Date:   Fri Dec 22 16:07:05 2017 +0000

    Factor out definition of depdendency fields.
---
 checks/python.pm | 3 ++-
 debian/changelog | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/checks/python.pm b/checks/python.pm
index 66c8e2f..f33b02b 100644
--- a/checks/python.pm
+++ b/checks/python.pm
@@ -27,6 +27,7 @@ use List::MoreUtils qw(any);
 
 use Lintian::Tags qw(tag);
 
+my @FIELDS = qw(Depends Pre-Depends Recommends Suggests);
 my @PYTHON2 = qw(python python2.7 python-dev);
 
 my %MISMATCHED_SUBSTVARS = (
@@ -94,7 +95,7 @@ sub _run_binary {
 
     # Python applications
     if ($pkg !~ /^python[23]?-/ and not any { $_ eq $pkg } @PYTHON2) {
-        for my $field (qw(Depends Pre-Depends Recommends Suggests)) {
+        for my $field (@FIELDS) {
             for my $dep (@PYTHON2) {
                 tag 'dependency-on-python-version-marked-for-end-of-life',
                   "($field: $dep)"
diff --git a/debian/changelog b/debian/changelog
index 96b31b6..0381849 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -16,6 +16,7 @@ lintian (2.5.66) UNRELEASED; urgency=medium
     + [CL] Warn about Python 2.x packages using ${python3:Depends} and
       Python 3.x packages using ${python:Depends}. Thanks to Mattia
       Rizzolo for the idea.  (Closes: #884676)
+    + [CL] Factor out definition of dependency fields.
   * checks/rules.{desc,pm}:
     + [CL] Check for override_dh_clean targets that are missing calls to
       dh_clean. Thanks to Andreas Beckmann for the idea.  (Closes: #884817)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: