[lintian] 01/01: Apply patch from Boud Roukema to improve the description of the binary-file-built-without-LFS-support tag. (Closes: #874078)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit f40064ca2ec72bbed05eba25b87aaea4c13ccb20
Author: Boud Roukema <boud-debian@cosmo.torun.pl>
Date: Sat Sep 2 22:09:55 2017 +0100
Apply patch from Boud Roukema to improve the description of the binary-file-built-without-LFS-support tag. (Closes: #874078)
Signed-off-by: Chris Lamb <lamby@debian.org>
---
checks/binaries.desc | 10 +++++++---
debian/changelog | 3 +++
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/checks/binaries.desc b/checks/binaries.desc
index 659c23f..87bbab1 100644
--- a/checks/binaries.desc
+++ b/checks/binaries.desc
@@ -439,11 +439,15 @@ Info: The listed ELF binary appears to be (partially) built without
To support large files, code review might be needed to make sure that
those files are not slurped into memory or mmap(2)ed, and that correct
64-bit data types are used (ex: off_t instead of ssize_t), etc. Once
- that has been done ensure <tt>_FILE_OFFSET_BITS</tt> is defined and
- set to 64 before the relevant files are included. This can be done by
+ that has been done ensure, if needed, that <tt>_FILE_OFFSET_BITS</tt>
+ is defined and
+ set to 64 before the relevant files are included. This can be done
+ conditionally by
using the <tt>AC_SYS_LARGEFILE</tt> macro with autoconf, or by appending
the output of <tt>getconf LFS_CFLAGS</tt> and <tt>getconf LFS_LDFLAGS</tt>
- to <tt>CFLAGS</tt> and <tt>LDFLAGS</tt> respectively.
+ to <tt>CFLAGS</tt> and <tt>LDFLAGS</tt> respectively. Functions such
+ as pwrite and pread should be replaced by pwrite64 and pread64 in
+ cases where <tt>_FILE_OFFSET_BITS</tt> is defined and set to 64.
.
Take into account that even if this tag is not emitted, that does not
mean the binary is LFS-safe (ie. no OOM conditions, file truncation
diff --git a/debian/changelog b/debian/changelog
index 7957da1..2881955 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,9 @@ lintian (2.5.53) UNRELEASED; urgency=medium
* checks/apache2.pm:
+ [CL] Fix an apache2-unparsable-dependency false positive by allowing
periods (".") in dependency names. (Closes: #873701)
+ * checks/binaries.pm:
+ [CL] Apply patch from Boud Roukema to improve the description of the
+ binary-file-built-without-LFS-support tag. (Closes: #874078)
* checks/changes.{pm,desc}:
+ [CL] Ignore DFSG-repacked packages when checking for upstream
source tarball signatures as they will never match by definition.
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: