[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#873520: lintian: Check for bad-distribution in debian/changelog too



Hey Jeremy,

> I was surprised to see that pyjunitxml 0.6-1.2 was accepted into
> Debian unstable with its debian/changelog still set to UNRELEASED. I
> guess the uploader managed to generate a valid .changes file.

I would be interested to know the story there!

> lintian already has a check for bad-distribution-in-changes-file

Indeed. A quick glance suggests that a little bit of refactoring would
be needed to avoid egregious code duplication between changes-file.pm
and changelog-file.pm, however.

Lintian devs; where might you suggest a "is_valid_distribution" utility
could live? It needs to do the -backports (etc.) stripping, etc.

Alternatively, could we just warn when $entries[0]->Distribution doesn't
match $info->field('distribution')..? Is this ever a sane thin to do?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-


Reply to: