[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#870829: Contradicting warnings/errors: useless-autoreconf-build-depends vs. missing-build-dependency-for-dh-addon





On Sat, Aug 5, 2017 at 6:25 PM, Mattia Rizzolo <mattia@debian.org> wrote:
On Sat, Aug 05, 2017 at 05:47:39PM +0200, Michael Stapelberg wrote:
> build-dependency was unnecessary with debhelper ≥ 10 and should be removed:
>
> W: mdocml source: useless-autoreconf-build-depends autotools-dev
>
> After doing that, lintian noted that the autotools_dev addon was missing a
> dependency on autotools-dev:
>
> E: mdocml source: missing-build-dependency-for-dh-addon autotools_dev => autotools-dev
>
> This error seems to directly contradict the earlier warning.
>
> Not only src:mdocml is affected: e.g. src:teg removed the build dependency in
> https://anonscm.debian.org/viewvc/pkg-games/packages/trunk/teg/debian/control?r1=15952&r2=15990
> and now shows up in
> https://lintian.debian.org/tags/missing-build-dependency-for-dh-addon.html.
>
> What course of action is correct? Which warning should be removed from lintian?


Neither of them.  The description might be a bit misleading, but it's an
actual "problem" in your package: you need not use
    --with autotools_dev
anymore, as starting with debhelper version 9.20160114 debhelper
includes an dh_update_autotools_config helper that is run for all
debhelper compat level.

Wow, I would have never guessed that. Can we add a more specific warning to lintian for this case? I expect the maintainers of all 372 source packages found by the search https://codesearch.debian.net/search?q=path%3Adebian%2Frules+with.*autotools_dev&perpkg=1 to eventually face this problem.
 

Also, dropping that `--with autotools_dev` switch will cast away all the
lintian warnings.

Done with https://anonscm.debian.org/git/collab-maint/mdocml.git/commit/?id=e655a7998c6e4b32c4cb55d48366f74e1bb1a194, thanks!
 

--
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-



--
Best regards,
Michael

Reply to: