Re: [lintian] 02/02: Warn if we see an unnecessary "Testsuite" header in debian/control.

[Niels Thykier <niels@thykier.net>]

Chris Lamb:
> This is an automated email from the git hooks/post-receive script.
> 
> lamby pushed a commit to branch master
> in repository lintian.
> 


Hi,

Thanks for improving the autopkgtests related tags. :)

> commit 7c1a32e91b5f9ad674a6f3f66a6a374028942556
> Author: Chris Lamb <lamby@debian.org>
> Date:   Sat Jul 29 22:05:38 2017 +0100
> 
> [...]
> index b25b024..cd71aba 100644
> --- a/checks/testsuite.pm
> +++ b/checks/testsuite.pm
> @@ -103,6 +103,9 @@ sub run {
>              }
>              check_control_contents($info, $path);
>          }
> +
> +        tag 'unnecessary-testsuite-header'
> +          if defined($info->source_field('testsuite'));
>      }
>      return;
>  }
> [...]
What about packages that use "autopkgtest-${class}" e.g.
"autopkgtest-pkg-perl"?  AFAIK, if you set Testsuite to one of these,
then autodep8 will skip its auto-detection and just generate the
autopkgtest code for the selected class.

So I think we might want to narrow that check to the field being set to
exactly "autopkgtest" (and not just that the field is present).

Thanks,
~Niels