[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#868178: lintian: enable r-data-without-readme-source check also for .RData files



Package: lintian
Severity: wishlist
Tags: patch


Hi,
Please find attached a patch that enable r-data-without-readme-source
check also for .RData files (with a upper-case D that is found in some
R packages [1]).
The patch also add reference about the decision from the FTP team.

Best regards,
Dylan

[1] https://codesearch.debian.net/search?q=%5C.RData
From 49f8d0b28710ace446cb99433d5da19292eba0e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dylan=20A=C3=AFssi?= <bob.dybian@gmail.com>
Date: Wed, 12 Jul 2017 21:27:57 +0200
Subject: [PATCH] Enable r-data-without-readme-source check also for .RData
 files

---
 checks/cruft.desc | 1 +
 checks/cruft.pm   | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/checks/cruft.desc b/checks/cruft.desc
index d0e1497..93ae0c5 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -878,6 +878,7 @@ Info: Many modules packaged for the R Project for Statistical Computing contain
  debian/README.source, which this package is missing.
  .
  Please add a README.source documenting the origins of these files.
+Ref: https://lists.debian.org/debian-devel/2013/09/msg00332.html
 
 Tag: file-contains-fixme-placeholder
 Severity: important
diff --git a/checks/cruft.pm b/checks/cruft.pm
index 5ed8b53..05d8901 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -652,7 +652,7 @@ sub find_cruft {
         }
 
         # Ensure we have a README.source for R data files
-        if (   $basename =~ m,\.(?:rda|Rda|rdata|Rdata)$,
+        if (   $basename =~ m,\.(?:rda|Rda|rdata|Rdata|RData)$,
             && $entry->is_file
             && !$info->index_resolved_path('debian/README.source')) {
             tag 'r-data-without-readme-source', $name;
-- 
2.1.4


Reply to: