[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#833007: lintian: suggest adding upstream metadata



Dylan:
> tags 833007 + patch
> thanks
> 
> Hi,
> 
> Please find attached a patch which also partially fix #731340 (in CC).
> This patch will emit the tag for many packages. I did not update
> t/tests/*/tags according to this new tag. I am waiting for some
> reviews of the patch to do the job.
> 
> Best regards,
> Dylan
> 

Hi Dylan,

Thanks for working on improving lintian.

Some remarks about your patch:

 * Code-wise the patch seems fine.

 * The tag description / help should probably have reference that
   explains what the upstream-metadata file is and how to write it.

 * Re: tests.  Instead of updating all tests, please add a small valid
   upstream metadata file in right part of the
     t/templates/tests/pedantic directory and use a pre_build hook in
   the tests that must not have an upstream metadata file.
   - t/tests/upstream-metadata-is-not-a-file/pre_build is probably a
     good choice for an example as it seems related.

Thanks,
~Niels


Reply to: