Control: tags -1 newcomer Axel Beckert: > Package: lintian > Version: 2.5.50.1 > Severity: wishlist > > Hi, > > [...] > > Only when I saw the graphic on his screen without the surrounding > context, I realized that the graph actually doesn't contain the tag name > at all. ([...]) > Agreed that is less helpful than it should have been. > So I propose to add at least the tag name to the SVG somewhere, > e.g. below the X axis, as a title or instead of "Tags". If we can afford > using more vertical space, I'd suggest to changing the legend as > follows: > > Tags ⇒ Tag <actual tag name> emitted > Packages ⇒ Packages which emitted <actual tag name> > Overridden ⇒ Tag <actual tag name> overridden > > (Maybe we need to use a smaller font, too.) > I am very happy to receive patches for improvements. I have attached the underlying data file so anyone can play around with it. To generate a graph from it, you will need to do the following: cp -a $LINTIAN_GIT_CHECKOUT/reporting/graphs/tags.gpi . sed -i 's/^tag=.*/tag="hardening-no-pie"/' tags.gpi mkdir tags gzip -dc < hardening-no-pie.dat.gz > tags/hardening-no-pie.dat cat <<EOF > common.gpi date_min=1458251889 date_max=1489787879 graph_dir="." history_dir="." EOF gnuplot tags.gpi The result will be produced in tags/hardening-no-pie.svg. The example above omits the vertical version seperators. If you want to play with those, then have a look in commands/reporting-html-reports.pm (look for gnuplot), which has the logic for generating the common.gpi with the version separators. Any DD can extract newer versions of the data file (and any other data set used for graphs) from lindsay.d.o at /srv/lintian.debian.org/history/tags. For non-DDs, I am happy to provide other data files on request. Patches to expose the data files on the website is also very welcome. :) > Another thing which is very similar is the file name of that images. Are > there reasons why the above mentioned graph file is named > "beeef37b8e3ee13c9d12dc0374b1f60f3f16c2acec234986cdabc5d2ad429ef8.svg" > and not "<actual tag name>.svg"? That would probably also provide > permanent URLs for passing links to just the graph around. > > [...] > This is a trick that to enable aggressive caching while ensuring we can push updates out when the image changes. I admit it is not super user friendly but I would like to keep the actual resources that way. I am happy to assist with patches to /also/ provide a "human readable" URL that redirects to the current version of the resource. Possibly by reusing the concept of a redirect file (like the one that powers the https://lintian.debian.org/source/lintian redirects) Thanks, ~Niels
Attachment:
hardening-no-pie.dat.gz
Description: GNU Zip compressed data