Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

[Niels Thykier <niels@thykier.net>]

On Tue, 27 Sep 2016 15:29:00 +0100 Chris Lamb <lamby@debian.org> wrote:
> Package: lintian
> Severity: wishlist
> Tags: patch
> 
> Hi,
> 
> Attached is the following:
> 

Hi,

Thanks for the patch.

It looks good and I only got two comments! :)

>   commit 288035a951de277d0248ce28c561fbf7f8646839
>   Author: Chris Lamb <lamby@debian.org>
>   Date:   Tue Sep 27 16:28:04 2016 +0200
>   
>       checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).
>       

Please shorten the synopsis and move the more length part into the
description.


>       Signed-off-by: Chris Lamb <lamby@debian.org>
>   
>    checks/init.d.desc          |  5 +++++
>    checks/init.d.pm            | 12 +++++++++---
>    t/tests/legacy-scripts/desc |  2 ++
>    t/tests/legacy-scripts/tags |  1 +
> [...]


Please create a non-legacy test case for new tags.  A long term goal is
to remove all the t/tests/legacy-* tests. :)

Thanks,
~Niels