[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/02: checks/copyright-file: Stop using Data::Alias



This is an automated email from the git hooks/post-receive script.

jwilk pushed a commit to branch master
in repository lintian.

commit 9841e66e9293ba40da01a164d02fd70ed661b998
Author: Jakub Wilk <jwilk@debian.org>
Date:   Fri Aug 19 22:44:02 2016 +0200

    checks/copyright-file: Stop using Data::Alias
    
    The use of Data::Alias was introduced in 516add8dc237 "to avoid copying
    large texts in memory". But Perl >= 5.20 has copy-on-write strings,
    so this optimization is no longer necessary.
---
 checks/copyright-file.pm | 3 +--
 debian/changelog         | 6 ++++++
 debian/control           | 2 --
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/checks/copyright-file.pm b/checks/copyright-file.pm
index a8e6183..ba00c96 100644
--- a/checks/copyright-file.pm
+++ b/checks/copyright-file.pm
@@ -36,7 +36,6 @@ use constant {
 
 use Encode qw(decode);
 use List::MoreUtils qw(any);
-use Data::Alias;
 
 use Lintian::Check qw(check_spelling spelling_tag_emitter);
 use Lintian::Data ();
@@ -416,7 +415,7 @@ sub check_names_texts {
             return sub { ${$_[0]} =~ $action };
         }
         return sub {
-            alias $_ = ${$_[0]};
+            $_ = ${$_[0]};
             return $action->();
         };
     };
diff --git a/debian/changelog b/debian/changelog
index 1ac854a..6528b95 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,9 @@ lintian (2.5.47) UNRELEASED; urgency=medium
 
   * checks/changelog-file.desc:
     + [JW] Fix typo.
+  * checks/copyright-file.pm:
+    + [JW] Stop using Data::Alias.  Thanks to Niko Tyni for the bug report.
+      (Closes: #834797)
   * checks/cruft.desc:
     + [JW] Fix typo.
   * checks/duplicate-files.desc:
@@ -27,6 +30,9 @@ lintian (2.5.47) UNRELEASED; urgency=medium
   * data/spelling/corrections*:
     + [JW] Add more corrections.
 
+  * debian/control:
+    + [JW] Drop now-unused libdata-alias-perl from (Build-)Depends.
+
  -- Niels Thykier <niels@thykier.net>  Sat, 13 Aug 2016 20:07:19 +0000
 
 lintian (2.5.46) unstable; urgency=medium
diff --git a/debian/control b/debian/control
index f4c9908..bf18ae6 100644
--- a/debian/control
+++ b/debian/control
@@ -51,7 +51,6 @@ Build-Depends: aspell,
                libtimedate-perl,
                liburi-perl,
                libyaml-libyaml-perl,
-               libdata-alias-perl,
                man-db,
                node-uglify,
                patchutils,
@@ -99,7 +98,6 @@ Depends: binutils,
          libtimedate-perl,
          liburi-perl,
          libyaml-libyaml-perl,
-         libdata-alias-perl,
          man-db,
          patchutils,
          perl,

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: