[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#805076: lintian: Only check PHP modules if they contain a .php file



Jochen Sprickerhof:
> Package: lintian
> Version: 2.5.46
> Followup-For: Bug #805076
> 
> Dear Maintainer,
> 
> there have been quite some releases since I opened this. Is there anything I
> can improve to get this included?
> 
> Cheers Jochen
> [...]

Hi,

Apologies for missing this.

It would be good to optimise this a bit.  Something like (from finger
memory rather than tested code):

  if (any { $_->basename =~ m/\.php$/i } $info->sorted_index) {

Would be a vast improvement over creating a huge string of all source
files in the package only to apply single regex to it.

Thanks,
~Niels


Reply to: