[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/02: c/r-sync-state: Refactor to avoid some hash lookups



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 50661ed0f5069997fb9834cb2cf883b8b84be139
Author: Niels Thykier <niels@thykier.net>
Date:   Wed Aug 3 18:44:54 2016 +0000

    c/r-sync-state: Refactor to avoid some hash lookups
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 commands/reporting-sync-state.pm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/commands/reporting-sync-state.pm b/commands/reporting-sync-state.pm
index 84754e3..42c2579 100644
--- a/commands/reporting-sync-state.pm
+++ b/commands/reporting-sync-state.pm
@@ -282,7 +282,7 @@ sub _parse_srcs_pg {
     my $dir = $paragraph->{'directory'}//'';
     my $group_id = $paragraph->{'package'} . '/' . $paragraph->{'version'};
     my $member_id = "source:${group_id}";
-    my (%data, %group_metadata);
+    my (%data, %group_metadata, $group_mirror_md);
     # only include the source if it has any binaries to be checked.
     # - Otherwise we may end up checking a source with no binaries
     #   (happens if the architecture is "behind" in building)
@@ -298,12 +298,12 @@ sub _parse_srcs_pg {
         last;
     }
 
-    $group_metadata{'mirror-metadata'}{'area'} = $extra_metadata->{'area'};
-    $group_metadata{'mirror-metadata'}{'maintainer'}
-      = $paragraph->{'maintainer'};
+    $group_mirror_md = $group_metadata{'mirror-metadata'};
+    $group_mirror_md->{'area'} = $extra_metadata->{'area'};
+    $group_mirror_md->{'maintainer'} = $paragraph->{'maintainer'};
     if (my $uploaders = $paragraph->{'uploaders'}) {
         my @ulist = split(/>\K\s*,\s*/, $uploaders);
-        $group_metadata{'mirror-metadata'}{'uploaders'} = \@ulist;
+        $group_mirror_md->{'uploaders'} = \@ulist;
     }
 
     add_member_to_group($state, $group_id, $member_id, \%data,

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: