[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#832771: lintian: c/systemd: Warn about .service files with a missing WantedBy target



Hi Chris!

* Chris Lamb <lamby@debian.org>, 2016-07-28, 20:48:
lintian: c/systemd: Warn about .service files with a missing WantedBy target
Updated patch attached, dropping "Certainty: certain".

It certainly shouldn't have been "certain", but you can't just drop Certainty; it's an obligatory field.

+ Forgetting to add such a line (eg. <tt>WantedBy=multi-user.target</tt>)

s/eg./e.g./ ? At least that's how we spell it elsewhere.

+        tag 'systemd-service-file-missing-wanted-by-key', $file,
+          unless extract_service_file_values($file, 'Install', 'WantedBy',1);

We should probably also check for RequiredBy.

--
Jakub Wilk


Reply to: